All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-api@vger.kernel.org, oleksandr@redhat.com,
	Suren Baghdasaryan <surenb@google.com>,
	Tim Murray <timmurray@google.com>,
	Daniel Colascione <dancol@google.com>,
	Sandeep Patil <sspatil@google.com>,
	Sonny Rao <sonnyrao@google.com>,
	Brian Geffon <bgeffon@google.com>, Michal Hocko <mhocko@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Shakeel Butt <shakeelb@google.com>,
	John Dias <joaodias@google.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	sj38.park@gmail.com, alexander.h.duyck@linux.intel.com,
	Jann Horn <jannh@google.com>, Minchan Kim <minchan@kernel.org>
Subject: [PATCH v5 6/7] mm/madvise: employ mmget_still_valid for write lock
Date: Fri, 14 Feb 2020 09:05:19 -0800	[thread overview]
Message-ID: <20200214170520.160271-7-minchan@kernel.org> (raw)
In-Reply-To: <20200214170520.160271-1-minchan@kernel.org>

From: Oleksandr Natalenko <oleksandr@redhat.com>

Do the very same trick as we already do since 04f5866e41fb. KSM hints
will require locking mmap_sem for write since they modify vm_flags, so
for remote KSM hinting this additional check is needed.

Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/madvise.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/madvise.c b/mm/madvise.c
index bbbfea93396a..762a68205e65 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -1117,6 +1117,8 @@ int do_madvise(struct task_struct *task, struct mm_struct *mm,
 	if (write) {
 		if (down_write_killable(&mm->mmap_sem))
 			return -EINTR;
+		if (current->mm != mm && !mmget_still_valid(mm))
+			goto skip_mm;
 	} else {
 		down_read(&mm->mmap_sem);
 	}
@@ -1167,6 +1169,7 @@ int do_madvise(struct task_struct *task, struct mm_struct *mm,
 	}
 out:
 	blk_finish_plug(&plug);
+skip_mm:
 	if (write)
 		up_write(&mm->mmap_sem);
 	else
-- 
2.25.0.265.gbab2e86ba0-goog


  parent reply	other threads:[~2020-02-14 17:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 17:05 [PATCH v5 0/7] introduce memory hinting API for external process Minchan Kim
2020-02-14 17:05 ` [PATCH v5 1/7] mm: pass task and mm to do_madvise Minchan Kim
2020-02-14 17:25   ` Jann Horn
2020-02-14 18:22     ` Jens Axboe
2020-02-14 18:45       ` Minchan Kim
2020-02-14 19:09         ` Jens Axboe
2020-02-14 19:31           ` Minchan Kim
2020-02-14 17:05 ` [PATCH v5 2/7] mm: introduce external memory hinting API Minchan Kim
2020-02-14 17:05 ` [PATCH v5 3/7] mm: check fatal signal pending of target process Minchan Kim
2020-02-14 17:05 ` [PATCH v5 4/7] pid: export pidfd_get_pid Minchan Kim
2020-02-17  7:59   ` Christoph Hellwig
2020-02-19  1:02     ` Minchan Kim
2020-02-14 17:05 ` [PATCH v5 5/7] mm: support both pid and pidfd for process_madvise Minchan Kim
2020-02-14 17:05 ` Minchan Kim [this message]
2020-02-14 17:05 ` [PATCH v5 7/7] mm/madvise: allow KSM hints for remote API Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214170520.160271-7-minchan@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=bgeffon@google.com \
    --cc=dancol@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jannh@google.com \
    --cc=joaodias@google.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=oleksandr@redhat.com \
    --cc=shakeelb@google.com \
    --cc=sj38.park@gmail.com \
    --cc=sonnyrao@google.com \
    --cc=sspatil@google.com \
    --cc=surenb@google.com \
    --cc=timmurray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.