From: Minchan Kim <minchan@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Jann Horn <jannh@google.com>, io-uring <io-uring@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux API <linux-api@vger.kernel.org>,
Oleksandr Natalenko <oleksandr@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
Tim Murray <timmurray@google.com>,
Daniel Colascione <dancol@google.com>,
Sandeep Patil <sspatil@google.com>,
Sonny Rao <sonnyrao@google.com>,
Brian Geffon <bgeffon@google.com>, Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
John Dias <joaodias@google.com>,
Joel Fernandes <joel@joelfernandes.org>,
sj38.park@gmail.com,
Alexander Duyck <alexander.h.duyck@linux.intel.com>
Subject: Re: [PATCH v5 1/7] mm: pass task and mm to do_madvise
Date: Fri, 14 Feb 2020 11:31:43 -0800 [thread overview]
Message-ID: <20200214193143.GB165785@google.com> (raw)
In-Reply-To: <93aadcc6-3ef5-4ea0-be6b-23c06862002e@kernel.dk>
On Fri, Feb 14, 2020 at 12:09:50PM -0700, Jens Axboe wrote:
> On 2/14/20 11:45 AM, Minchan Kim wrote:
> > diff --git a/fs/io_uring.c b/fs/io_uring.c
> > index 63beda9bafc5..1c7e9cd6c8ce 100644
> > --- a/fs/io_uring.c
> > +++ b/fs/io_uring.c
> > @@ -2736,7 +2736,7 @@ static int io_madvise(struct io_kiocb *req, struct io_kiocb **nxt,
> > if (force_nonblock)
> > return -EAGAIN;
> >
> > - ret = do_madvise(ma->addr, ma->len, ma->advice);
> > + ret = do_madvise(NULL, current->mm, ma->addr, ma->len, ma->advice);
> > if (ret < 0)
> > req_set_fail_links(req);
> > io_cqring_add_event(req, ret);
>
> I think we want to use req->work.mm here - it'll be the same as
> current->mm at this point, but it makes it clear that we're using a
> grabbed mm.
Will fix at respin. Thanks for the review!
next prev parent reply other threads:[~2020-02-14 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 17:05 [PATCH v5 0/7] introduce memory hinting API for external process Minchan Kim
2020-02-14 17:05 ` [PATCH v5 1/7] mm: pass task and mm to do_madvise Minchan Kim
2020-02-14 17:25 ` Jann Horn
2020-02-14 18:22 ` Jens Axboe
2020-02-14 18:45 ` Minchan Kim
2020-02-14 19:09 ` Jens Axboe
2020-02-14 19:31 ` Minchan Kim [this message]
2020-02-14 17:05 ` [PATCH v5 2/7] mm: introduce external memory hinting API Minchan Kim
2020-02-14 17:05 ` [PATCH v5 3/7] mm: check fatal signal pending of target process Minchan Kim
2020-02-14 17:05 ` [PATCH v5 4/7] pid: export pidfd_get_pid Minchan Kim
2020-02-17 7:59 ` Christoph Hellwig
2020-02-19 1:02 ` Minchan Kim
2020-02-14 17:05 ` [PATCH v5 5/7] mm: support both pid and pidfd for process_madvise Minchan Kim
2020-02-14 17:05 ` [PATCH v5 6/7] mm/madvise: employ mmget_still_valid for write lock Minchan Kim
2020-02-14 17:05 ` [PATCH v5 7/7] mm/madvise: allow KSM hints for remote API Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214193143.GB165785@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=bgeffon@google.com \
--cc=dancol@google.com \
--cc=hannes@cmpxchg.org \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=joaodias@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=oleksandr@redhat.com \
--cc=shakeelb@google.com \
--cc=sj38.park@gmail.com \
--cc=sonnyrao@google.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.