From: Mark Brown <broonie@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-kernel@vger.kernel.org, Merlijn Wajer <merlijn@wizzup.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
"Arthur D ." <spinal.by@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card
Date: Fri, 14 Feb 2020 20:05:37 +0000 [thread overview]
Message-ID: <20200214200537.GR4827@sirena.org.uk> (raw)
In-Reply-To: <20200214170559.GA64767@atomide.com>
[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]
On Fri, Feb 14, 2020 at 09:05:59AM -0800, Tony Lindgren wrote:
> * Mark Brown <broonie@kernel.org> [200214 12:50]:
> > We really shouldn't need dummy DAIs at all I think, if we do it feels
> > like there's a problem. It's quite possible that there is actually a
> > problem here though...
> It's dummy in the droid4 voice call case as mcbsp is not the clock-master
> and there's nothing to configure for mcbsp.
If the McBSP is doing anything at all it should still be properly
represented with the actual device rather than a dummy otherwise we'll
most likely get confused at some point. If it's not doing anything then
we shouldn't even need the dummy. But perhaps I'm confused about this
particular system, I remember some of the OMAP designs were a bit fun.
> But I guess in some cases mcbsp could be the clock-master and then the
> secondary DAI would have ops.
It'd be a bit of an unusual clock design for a phone but yeah.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
"Arthur D ." <spinal.by@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card
Date: Fri, 14 Feb 2020 20:05:37 +0000 [thread overview]
Message-ID: <20200214200537.GR4827@sirena.org.uk> (raw)
In-Reply-To: <20200214170559.GA64767@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Fri, Feb 14, 2020 at 09:05:59AM -0800, Tony Lindgren wrote:
> * Mark Brown <broonie@kernel.org> [200214 12:50]:
> > We really shouldn't need dummy DAIs at all I think, if we do it feels
> > like there's a problem. It's quite possible that there is actually a
> > problem here though...
> It's dummy in the droid4 voice call case as mcbsp is not the clock-master
> and there's nothing to configure for mcbsp.
If the McBSP is doing anything at all it should still be properly
represented with the actual device rather than a dummy otherwise we'll
most likely get confused at some point. If it's not doing anything then
we shouldn't even need the dummy. But perhaps I'm confused about this
particular system, I remember some of the OMAP designs were a bit fun.
> But I guess in some cases mcbsp could be the clock-master and then the
> secondary DAI would have ops.
It'd be a bit of an unusual clock design for a phone but yeah.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-14 20:06 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 17:16 [alsa-devel] [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card Tony Lindgren
2020-02-11 17:16 ` Tony Lindgren
2020-02-12 8:02 ` [alsa-devel] " Peter Ujfalusi
2020-02-12 8:02 ` Peter Ujfalusi
2020-02-12 8:02 ` Peter Ujfalusi
2020-02-12 14:35 ` [alsa-devel] " Tony Lindgren
2020-02-12 14:35 ` Tony Lindgren
2020-02-14 0:34 ` [alsa-devel] " Sebastian Reichel
2020-02-14 0:34 ` Sebastian Reichel
2020-02-14 1:34 ` [alsa-devel] " Tony Lindgren
2020-02-14 1:34 ` Tony Lindgren
2020-02-14 13:04 ` [alsa-devel] " Sebastian Reichel
2020-02-14 13:04 ` Sebastian Reichel
2020-02-14 17:09 ` [alsa-devel] " Tony Lindgren
2020-02-14 17:09 ` Tony Lindgren
2020-02-18 14:04 ` Sebastian Reichel
2020-02-18 14:04 ` Sebastian Reichel
2020-02-18 14:19 ` Tony Lindgren
2020-02-18 14:19 ` Tony Lindgren
2020-02-18 16:35 ` Sebastian Reichel
2020-02-18 16:35 ` Sebastian Reichel
2020-02-14 12:41 ` [alsa-devel] " Peter Ujfalusi
2020-02-14 12:41 ` Peter Ujfalusi
2020-02-14 12:49 ` [alsa-devel] " Mark Brown
2020-02-14 12:49 ` Mark Brown
2020-02-14 17:05 ` [alsa-devel] " Tony Lindgren
2020-02-14 17:05 ` Tony Lindgren
2020-02-14 20:05 ` Mark Brown [this message]
2020-02-14 20:05 ` Mark Brown
2020-02-14 17:03 ` [alsa-devel] " Tony Lindgren
2020-02-14 17:03 ` Tony Lindgren
2020-02-17 1:38 ` [alsa-devel] " Kuninori Morimoto
2020-02-17 1:38 ` Kuninori Morimoto
2020-02-17 5:25 ` [alsa-devel] " Kuninori Morimoto
2020-02-17 5:25 ` Kuninori Morimoto
2020-02-17 12:09 ` [alsa-devel] " Peter Ujfalusi
2020-02-17 12:09 ` Peter Ujfalusi
2020-02-17 23:10 ` Tony Lindgren
2020-02-17 23:10 ` Tony Lindgren
2020-02-17 23:36 ` Tony Lindgren
2020-02-17 23:36 ` Tony Lindgren
2020-02-18 15:26 ` Peter Ujfalusi
2020-02-18 15:26 ` Peter Ujfalusi
2020-02-18 15:34 ` Tony Lindgren
2020-02-18 15:34 ` Tony Lindgren
2020-02-18 12:43 ` Peter Ujfalusi
2020-02-18 12:43 ` Peter Ujfalusi
2020-02-18 15:28 ` Tony Lindgren
2020-02-18 15:28 ` Tony Lindgren
2020-02-20 14:07 ` Peter Ujfalusi
2020-02-20 14:07 ` Peter Ujfalusi
2020-02-20 20:13 ` Tony Lindgren
2020-02-20 20:13 ` Tony Lindgren
2020-02-21 14:07 ` Peter Ujfalusi
2020-02-21 14:07 ` Peter Ujfalusi
2020-02-18 21:16 ` Sebastian Reichel
2020-02-18 21:16 ` Sebastian Reichel
2020-02-20 14:15 ` Peter Ujfalusi
2020-02-20 14:15 ` Peter Ujfalusi
2020-02-20 20:15 ` Tony Lindgren
2020-02-20 20:15 ` Tony Lindgren
2020-02-21 13:20 ` Peter Ujfalusi
2020-02-21 13:20 ` Peter Ujfalusi
2020-02-21 18:08 ` Tony Lindgren
2020-02-21 18:08 ` Tony Lindgren
2020-02-20 20:47 ` Sebastian Reichel
2020-02-20 20:47 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214200537.GR4827@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@bitmer.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=peter.ujfalusi@ti.com \
--cc=spinal.by@gmail.com \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.