All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
	kevin.tian@intel.com, linux-pci@vger.kernel.org,
	jasowang@redhat.com, virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com,
	jacob.jun.pan@intel.com, bhelgaas@google.com
Subject: Re: [PATCH 3/3] iommu/virtio: Enable x86 support
Date: Sun, 16 Feb 2020 04:50:33 -0500	[thread overview]
Message-ID: <20200216045006-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <311a1885-c619-3c8d-29dd-14fbfbf74898@arm.com>

On Fri, Feb 14, 2020 at 04:57:11PM +0000, Robin Murphy wrote:
> On 14/02/2020 4:04 pm, Jean-Philippe Brucker wrote:
> > With the built-in topology description in place, x86 platforms can now
> > use the virtio-iommu.
> > 
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > ---
> >   drivers/iommu/Kconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > index 068d4e0e3541..adcbda44d473 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -508,8 +508,9 @@ config HYPERV_IOMMU
> >   config VIRTIO_IOMMU
> >   	bool "Virtio IOMMU driver"
> >   	depends on VIRTIO=y
> > -	depends on ARM64
> > +	depends on (ARM64 || X86)
> >   	select IOMMU_API
> > +	select IOMMU_DMA
> 
> Can that have an "if X86" for clarity? AIUI it's not necessary for
> virtio-iommu itself (and really shouldn't be), but is merely to satisfy the
> x86 arch code's expectation that IOMMU drivers bring their own DMA ops,
> right?
> 
> Robin.

In fact does not this work on any platform now?

> >   	select INTERVAL_TREE
> >   	help
> >   	  Para-virtualised IOMMU driver with virtio.
> > 

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
	iommu@lists.linux-foundation.org,
	virtualization@lists.linux-foundation.org,
	linux-pci@vger.kernel.org, kevin.tian@intel.com,
	sebastien.boeuf@intel.com, jacob.jun.pan@intel.com,
	bhelgaas@google.com, jasowang@redhat.com
Subject: Re: [PATCH 3/3] iommu/virtio: Enable x86 support
Date: Sun, 16 Feb 2020 04:50:33 -0500	[thread overview]
Message-ID: <20200216045006-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <311a1885-c619-3c8d-29dd-14fbfbf74898@arm.com>

On Fri, Feb 14, 2020 at 04:57:11PM +0000, Robin Murphy wrote:
> On 14/02/2020 4:04 pm, Jean-Philippe Brucker wrote:
> > With the built-in topology description in place, x86 platforms can now
> > use the virtio-iommu.
> > 
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > ---
> >   drivers/iommu/Kconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > index 068d4e0e3541..adcbda44d473 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -508,8 +508,9 @@ config HYPERV_IOMMU
> >   config VIRTIO_IOMMU
> >   	bool "Virtio IOMMU driver"
> >   	depends on VIRTIO=y
> > -	depends on ARM64
> > +	depends on (ARM64 || X86)
> >   	select IOMMU_API
> > +	select IOMMU_DMA
> 
> Can that have an "if X86" for clarity? AIUI it's not necessary for
> virtio-iommu itself (and really shouldn't be), but is merely to satisfy the
> x86 arch code's expectation that IOMMU drivers bring their own DMA ops,
> right?
> 
> Robin.

In fact does not this work on any platform now?

> >   	select INTERVAL_TREE
> >   	help
> >   	  Para-virtualised IOMMU driver with virtio.
> > 


  reply	other threads:[~2020-02-16  9:50 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 16:04 [PATCH 0/3] virtio-iommu on non-devicetree platforms Jean-Philippe Brucker
2020-02-14 16:04 ` Jean-Philippe Brucker
2020-02-14 16:04 ` Jean-Philippe Brucker
2020-02-14 16:04 ` [PATCH 1/3] iommu/virtio: Add topology description to virtio-iommu config space Jean-Philippe Brucker
2020-02-14 16:04   ` Jean-Philippe Brucker
2020-02-14 16:04   ` Jean-Philippe Brucker
2020-02-14 16:04 ` [PATCH 2/3] PCI: Add DMA configuration for virtual platforms Jean-Philippe Brucker
2020-02-14 16:04   ` Jean-Philippe Brucker
2020-02-14 16:04   ` Jean-Philippe Brucker
2020-02-14 17:03   ` Robin Murphy
2020-02-14 17:03     ` Robin Murphy
2020-02-17  9:12     ` Jean-Philippe Brucker
2020-02-17  9:12       ` Jean-Philippe Brucker
2020-02-14 16:04 ` [PATCH 3/3] iommu/virtio: Enable x86 support Jean-Philippe Brucker
2020-02-14 16:04   ` Jean-Philippe Brucker
2020-02-14 16:04   ` Jean-Philippe Brucker
2020-02-14 16:57   ` Robin Murphy
2020-02-14 16:57     ` Robin Murphy
2020-02-14 16:57     ` Robin Murphy
2020-02-16  9:50     ` Michael S. Tsirkin [this message]
2020-02-16  9:50       ` Michael S. Tsirkin
2020-02-17  9:01       ` Jean-Philippe Brucker
2020-02-17  9:01         ` Jean-Philippe Brucker
2020-02-17  9:01         ` Jean-Philippe Brucker
2020-02-17 13:01         ` Michael S. Tsirkin
2020-02-17 13:01           ` Michael S. Tsirkin
2020-02-17 13:22           ` Robin Murphy
2020-02-17 13:22             ` Robin Murphy
2020-02-17 13:31             ` Michael S. Tsirkin
2020-02-17 13:31               ` Michael S. Tsirkin
2020-02-17 14:10               ` Robin Murphy
2020-02-17 14:10                 ` Robin Murphy
  -- strict thread matches above, loose matches on Subject: below --
2021-03-16 19:16 [PATCH 0/3] Add support for ACPI VIOT Jean-Philippe Brucker
2021-03-16 19:16 ` [PATCH 3/3] iommu/virtio: Enable x86 support Jean-Philippe Brucker
2021-03-16 19:16   ` Jean-Philippe Brucker
2021-03-16 19:16   ` Jean-Philippe Brucker
2021-03-18 10:44   ` Joerg Roedel
2021-03-18 10:44     ` Joerg Roedel
2021-03-18 10:44     ` Joerg Roedel
2021-03-18 11:43   ` Robin Murphy
2021-03-18 11:43     ` Robin Murphy
2021-03-18 11:43     ` Robin Murphy
2021-04-15 15:14     ` Jean-Philippe Brucker
2021-04-15 15:14       ` Jean-Philippe Brucker
2021-04-15 15:14       ` Jean-Philippe Brucker
2021-03-18 18:28   ` Michael S. Tsirkin
2021-03-18 18:28     ` Michael S. Tsirkin
2021-03-18 18:28     ` Michael S. Tsirkin
2021-04-15 15:15     ` Jean-Philippe Brucker
2021-04-15 15:15       ` Jean-Philippe Brucker
2021-04-15 15:15       ` Jean-Philippe Brucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216045006-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@intel.com \
    --cc=jasowang@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sebastien.boeuf@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.