All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	Rob Herring <robh@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h5: Fix PMU compatible
Date: Mon, 17 Feb 2020 18:49:06 +0100	[thread overview]
Message-ID: <20200217174906.ecvsonprelrbvyv2@gilmour.lan> (raw)
In-Reply-To: <20200214180404.24d67f86@donnerap.cambridge.arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 1048 bytes --]

Hi Andre,

On Fri, Feb 14, 2020 at 06:04:04PM +0000, Andre Przywara wrote:
> > The commit c35a516a4618 ("arm64: dts: allwinner: H5: Add PMU node")
> > introduced support for the PMU found on the Allwinner H5. However, the
> > binding only allows for a single compatible, while the patch was adding
> > two.
>
> Maxime, thanks for bringing this up, was that found by some
> validation tool?

Indeed.

> And while this is true, I wonder if this was intentional?

Either the YAML file:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/pmu.yaml

Or the text file that was there before it:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/pmu.txt?id=v5.0

Make it pretty clear that only a single entry is expected

> I see several other combinations of PMU compatibles in the tree.

I've probably sent around 50-100 patches for DT not following the
binding on Allwinner platforms alone, so it doesn't really surprise me
:)

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2020-02-17 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  9:55 [PATCH 1/2] arm64: dts: allwinner: h5: Fix PMU compatible Maxime Ripard
2020-02-10  9:56 ` [PATCH 2/2] arm64: dts: allwinner: h6: " Maxime Ripard
2020-02-25  9:03   ` Maxime Ripard
2020-02-14 18:04 ` [PATCH 1/2] arm64: dts: allwinner: h5: " Andre Przywara
2020-02-14 18:18   ` Robin Murphy
2020-02-17 17:49   ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217174906.ecvsonprelrbvyv2@gilmour.lan \
    --to=maxime@cerno.tech \
    --cc=Mark.Rutland@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.