* [Buildroot] [PATCH] package/openFPGALoader: new package
@ 2020-02-17 18:18 Jean Burgat
2020-02-17 18:18 ` [Buildroot] [PATCH] propose myself as maintainer for package/openFPGALoader Jean Burgat
2020-02-17 18:43 ` [Buildroot] [PATCH] package/openFPGALoader: new package Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Jean Burgat @ 2020-02-17 18:18 UTC (permalink / raw)
To: buildroot
Signed-off-by: Jean Burgat <jeanburgat33@gmail.com>
---
package/Config.in | 1 +
package/openFPGALoader/Config.in | 18 ++++++++++++++++++
package/openFPGALoader/openFPGALoader.hash | 3 +++
package/openFPGALoader/openFPGALoader.mk | 13 +++++++++++++
4 files changed, 35 insertions(+)
create mode 100644 package/openFPGALoader/Config.in
create mode 100644 package/openFPGALoader/openFPGALoader.hash
create mode 100644 package/openFPGALoader/openFPGALoader.mk
diff --git a/package/Config.in b/package/Config.in
index dfa3f34b9d..daf2feaae9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -499,6 +499,7 @@ endmenu
source "package/ofono/Config.in"
source "package/on2-8170-modules/Config.in"
source "package/open2300/Config.in"
+ source "package/openFPGALoader/Config.in"
source "package/openipmi/Config.in"
source "package/openocd/Config.in"
source "package/openpowerlink/Config.in"
diff --git a/package/openFPGALoader/Config.in b/package/openFPGALoader/Config.in
new file mode 100644
index 0000000000..0e96e81906
--- /dev/null
+++ b/package/openFPGALoader/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_OPENFPGALOADER
+ bool "openFPGALoader"
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+ depends on BR2_TOOLCHAIN_USES_GLIBC # argp
+ depends on BR2_PACKAGE_HAS_UDEV
+ depends on BR2_INSTALL_LIBSTDCPP # libftdipp1
+ depends on BR2_USE_WCHAR # libftdipp1
+ select BR2_PACKAGE_LIBFTDI1
+ select BR2_PACKAGE_LIBFTDI1_LIBFTDIPP1
+ help
+ Universal utility for programming FPGA
+
+ https://github.com/trabucayre/openFPGALoader/
+
+comment "openFPGALoader needs a glibc toolchain w/ threads, wchar, C++, udev"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
+ !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
+ depends on !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/openFPGALoader/openFPGALoader.hash b/package/openFPGALoader/openFPGALoader.hash
new file mode 100644
index 0000000000..1e65809fd3
--- /dev/null
+++ b/package/openFPGALoader/openFPGALoader.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 fcff4999164ee2d3734f16b7f1d2063b3a68e237921e8d63c2afe75e16cdc7ce openFPGALoader-849e5751e06d4d00f323205d5f02ee01f9f59a61.tar.gz
+sha256 8486a10c4393cee1c25392769ddd3b2d6c242d6ec7928e1414efff7dfb2f07ef LICENSE
diff --git a/package/openFPGALoader/openFPGALoader.mk b/package/openFPGALoader/openFPGALoader.mk
new file mode 100644
index 0000000000..6706e7ffbf
--- /dev/null
+++ b/package/openFPGALoader/openFPGALoader.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# openFPGALoader
+#
+################################################################################
+
+OPENFPGALOADER_VERSION = 849e5751e06d4d00f323205d5f02ee01f9f59a61
+OPENFPGALOADER_SITE = $(call github,trabucayre,openFPGALoader,$(OPENFPGALOADER_VERSION))
+OPENFPGALOADER_LICENSE = AGPL-3.0
+OPENFPGALOADER_LICENSE_FILES = LICENSE
+OPENFPGALOADER_DEPENDENCIES = libftdi1 udev
+
+$(eval $(cmake-package))
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] propose myself as maintainer for package/openFPGALoader
2020-02-17 18:18 [Buildroot] [PATCH] package/openFPGALoader: new package Jean Burgat
@ 2020-02-17 18:18 ` Jean Burgat
2020-02-17 18:44 ` Thomas Petazzoni
2020-02-17 18:43 ` [Buildroot] [PATCH] package/openFPGALoader: new package Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Jean Burgat @ 2020-02-17 18:18 UTC (permalink / raw)
To: buildroot
Signed-off-by: Jean Burgat <jeanburgat33@gmail.com>
---
DEVELOPERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/DEVELOPERS b/DEVELOPERS
index e4a3bcb24a..e4bc87bab3 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1216,6 +1216,9 @@ F: package/quota/
N: Jason Pruitt <jrspruitt@gmail.com>
F: package/librtlsdr/
+N: Jean Burgat <jeanburgat33@gmail.com>
+F: package/openFPGALoader
+
N: Jens Kleintje <scooby22@web.de>
F: package/gcnano-binaries/
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] propose myself as maintainer for package/openFPGALoader
2020-02-17 18:18 ` [Buildroot] [PATCH] propose myself as maintainer for package/openFPGALoader Jean Burgat
@ 2020-02-17 18:44 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-02-17 18:44 UTC (permalink / raw)
To: buildroot
On Mon, 17 Feb 2020 19:18:25 +0100
Jean Burgat <jeanburgat33@gmail.com> wrote:
> Signed-off-by: Jean Burgat <jeanburgat33@gmail.com>
> ---
> DEVELOPERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index e4a3bcb24a..e4bc87bab3 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1216,6 +1216,9 @@ F: package/quota/
> N: Jason Pruitt <jrspruitt@gmail.com>
> F: package/librtlsdr/
>
> +N: Jean Burgat <jeanburgat33@gmail.com>
> +F: package/openFPGALoader
Ah, here is the DEVELOPERS entry. Could you merge this with the patch
adding the package, and also add a final / to package/openfpgaloader/
(all lower case).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/openFPGALoader: new package
2020-02-17 18:18 [Buildroot] [PATCH] package/openFPGALoader: new package Jean Burgat
2020-02-17 18:18 ` [Buildroot] [PATCH] propose myself as maintainer for package/openFPGALoader Jean Burgat
@ 2020-02-17 18:43 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-02-17 18:43 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for your contribution! See below for a number of comments.
On Mon, 17 Feb 2020 19:18:24 +0100
Jean Burgat <jeanburgat33@gmail.com> wrote:
> Signed-off-by: Jean Burgat <jeanburgat33@gmail.com>
> ---
> package/Config.in | 1 +
> package/openFPGALoader/Config.in | 18 ++++++++++++++++++
> package/openFPGALoader/openFPGALoader.hash | 3 +++
> package/openFPGALoader/openFPGALoader.mk | 13 +++++++++++++
> 4 files changed, 35 insertions(+)
Could you add an entry to the DEVELOPERS file for this package ?
Also, could you name the package openfpgaloader, i.e in lower-case ?
> diff --git a/package/openFPGALoader/Config.in b/package/openFPGALoader/Config.in
> new file mode 100644
> index 0000000000..0e96e81906
> --- /dev/null
> +++ b/package/openFPGALoader/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_OPENFPGALOADER
> + bool "openFPGALoader"
bool "openfpgaloader"
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
This dependency is also because of libftdi1
> + depends on BR2_TOOLCHAIN_USES_GLIBC # argp
Use the argp-standalone package to provide argp functionality for
non-glibc toolchains.
> + depends on BR2_PACKAGE_HAS_UDEV
> + depends on BR2_INSTALL_LIBSTDCPP # libftdipp1
> + depends on BR2_USE_WCHAR # libftdipp1
> + select BR2_PACKAGE_LIBFTDI1
> + select BR2_PACKAGE_LIBFTDI1_LIBFTDIPP1
> + help
> + Universal utility for programming FPGA
> +
> + https://github.com/trabucayre/openFPGALoader/
> +
> +comment "openFPGALoader needs a glibc toolchain w/ threads, wchar, C++, udev"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
> + !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
> + depends on !BR2_TOOLCHAIN_USES_GLIBC
So here you will be able to lift the glibc dependency thanks to
argp-standalone.
> diff --git a/package/openFPGALoader/openFPGALoader.mk b/package/openFPGALoader/openFPGALoader.mk
> new file mode 100644
> index 0000000000..6706e7ffbf
> --- /dev/null
> +++ b/package/openFPGALoader/openFPGALoader.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# openFPGALoader
lower case.
> +#
> +################################################################################
> +
> +OPENFPGALOADER_VERSION = 849e5751e06d4d00f323205d5f02ee01f9f59a61
> +OPENFPGALOADER_SITE = $(call github,trabucayre,openFPGALoader,$(OPENFPGALOADER_VERSION))
> +OPENFPGALOADER_LICENSE = AGPL-3.0
Interesting to use the AGPL for such a project, but oh well :)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-17 18:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-17 18:18 [Buildroot] [PATCH] package/openFPGALoader: new package Jean Burgat
2020-02-17 18:18 ` [Buildroot] [PATCH] propose myself as maintainer for package/openFPGALoader Jean Burgat
2020-02-17 18:44 ` Thomas Petazzoni
2020-02-17 18:43 ` [Buildroot] [PATCH] package/openFPGALoader: new package Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.