From: Andrew Lunn <andrew@lunn.ch>
To: Esben Haabendal <esben@geanix.com>
Cc: netdev@vger.kernel.org, "Michal Simek" <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, "Petr Štetiar" <ynezz@true.cz>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters
Date: Tue, 18 Feb 2020 14:39:43 +0100 [thread overview]
Message-ID: <20200218133943.GA10541@lunn.ch> (raw)
In-Reply-To: <20200218082741.7710-1-esben@geanix.com>
Hi Esben
> + if (ec->tx_coalesce_usecs)
> + lp->coalesce_delay_tx =
> + min(255U, (ec->tx_coalesce_usecs * 100) / 512);
> +
> + pr_info("%d -> %d %d -> %d\n",
> + ec->rx_coalesce_usecs, lp->coalesce_delay_rx,
> + ec->tx_coalesce_usecs, lp->coalesce_delay_tx);
I guess this is left over from debug? You don't actually want it here?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Esben Haabendal <esben@geanix.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
"Michal Simek" <michal.simek@xilinx.com>,
"Petr Štetiar" <ynezz@true.cz>
Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters
Date: Tue, 18 Feb 2020 14:39:43 +0100 [thread overview]
Message-ID: <20200218133943.GA10541@lunn.ch> (raw)
In-Reply-To: <20200218082741.7710-1-esben@geanix.com>
Hi Esben
> + if (ec->tx_coalesce_usecs)
> + lp->coalesce_delay_tx =
> + min(255U, (ec->tx_coalesce_usecs * 100) / 512);
> +
> + pr_info("%d -> %d %d -> %d\n",
> + ec->rx_coalesce_usecs, lp->coalesce_delay_rx,
> + ec->tx_coalesce_usecs, lp->coalesce_delay_tx);
I guess this is left over from debug? You don't actually want it here?
Andrew
next prev parent reply other threads:[~2020-02-18 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 8:27 [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters Esben Haabendal
2020-02-18 8:27 ` Esben Haabendal
2020-02-18 13:39 ` Andrew Lunn [this message]
2020-02-18 13:39 ` Andrew Lunn
2020-02-18 14:28 ` Esben Haabendal
2020-02-18 14:28 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218133943.GA10541@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=esben@geanix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.