From: Christoph Hellwig <hch@infradead.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
hch@infradead.org, dan.j.williams@intel.com,
vishal.l.verma@intel.com, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH v4 3/7] dax, pmem: Add a dax operation zero_page_range
Date: Tue, 18 Feb 2020 09:10:06 -0800 [thread overview]
Message-ID: <20200218171006.GC30766@infradead.org> (raw)
In-Reply-To: <20200217181653.4706-4-vgoyal@redhat.com>
> +static int pmem_dax_zero_page_range(struct dax_device *dax_dev, u64 offset,
> + size_t len)
> +{
> + struct pmem_device *pmem = dax_get_private(dax_dev);
> + blk_status_t rc;
> +
> + rc = pmem_do_write(pmem, ZERO_PAGE(0), 0, offset, len);
> + return blk_status_to_errno(rc);
No real need for the rc variable here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
hch@infradead.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH v4 3/7] dax, pmem: Add a dax operation zero_page_range
Date: Tue, 18 Feb 2020 09:10:06 -0800 [thread overview]
Message-ID: <20200218171006.GC30766@infradead.org> (raw)
In-Reply-To: <20200217181653.4706-4-vgoyal@redhat.com>
> +static int pmem_dax_zero_page_range(struct dax_device *dax_dev, u64 offset,
> + size_t len)
> +{
> + struct pmem_device *pmem = dax_get_private(dax_dev);
> + blk_status_t rc;
> +
> + rc = pmem_do_write(pmem, ZERO_PAGE(0), 0, offset, len);
> + return blk_status_to_errno(rc);
No real need for the rc variable here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-02-18 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 18:16 [PATCH v4 0/7] dax/pmem: Provide a dax operation to zero range of memory Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-17 18:16 ` [PATCH v4 1/7] pmem: Add functions for reading/writing page to/from pmem Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-18 17:07 ` [dm-devel] " Christoph Hellwig
2020-02-18 17:07 ` Christoph Hellwig
2020-02-17 18:16 ` [PATCH v4 2/7] pmem: Enable pmem_do_write() to deal with arbitrary ranges Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-18 17:09 ` [dm-devel] " Christoph Hellwig
2020-02-18 17:09 ` Christoph Hellwig
2020-02-18 21:10 ` Vivek Goyal
2020-02-18 21:10 ` Vivek Goyal
2020-02-17 18:16 ` [PATCH v4 3/7] dax, pmem: Add a dax operation zero_page_range Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-18 17:10 ` Christoph Hellwig [this message]
2020-02-18 17:10 ` [dm-devel] " Christoph Hellwig
2020-02-17 18:16 ` [PATCH v4 4/7] s390,dcssblk,dax: Add dax zero_page_range operation to dcssblk driver Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-17 18:16 ` [PATCH v4 5/7] dm,dax: Add dax zero_page_range operation Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-17 18:16 ` [PATCH v4 6/7] dax,iomap: Start using dax native zero_page_range() Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
2020-02-17 18:16 ` [PATCH v4 7/7] dax,iomap: Add helper dax_iomap_zero() to zero a range Vivek Goyal
2020-02-17 18:16 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218171006.GC30766@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vgoyal@redhat.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.