All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wambui Karuga <wambui.karugax@gmail.com>
To: bskeggs@redhat.com, airlied@linux.ie, daniel@ffwll.ch
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: [PATCH] drm/nouveau: remove checks for return value of debugfs functions
Date: Tue, 18 Feb 2020 20:28:17 +0300	[thread overview]
Message-ID: <20200218172821.18378-6-wambui.karugax@gmail.com> (raw)
In-Reply-To: <20200218172821.18378-1-wambui.karugax@gmail.com>

As there is no need to check for the return value of debugfs_create_file
and drm_debugfs_create_files, remove unnecessary checks and error
handling in nouveau_drm_debugfs_init.

Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
---
 drivers/gpu/drm/nouveau/nouveau_debugfs.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index 7dfbbbc1beea..15a3d40edf02 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -222,22 +222,18 @@ nouveau_drm_debugfs_init(struct drm_minor *minor)
 {
 	struct nouveau_drm *drm = nouveau_drm(minor->dev);
 	struct dentry *dentry;
-	int i, ret;
+	int i;
 
 	for (i = 0; i < ARRAY_SIZE(nouveau_debugfs_files); i++) {
-		dentry = debugfs_create_file(nouveau_debugfs_files[i].name,
-					     S_IRUGO | S_IWUSR,
-					     minor->debugfs_root, minor->dev,
-					     nouveau_debugfs_files[i].fops);
-		if (!dentry)
-			return -ENOMEM;
+		debugfs_create_file(nouveau_debugfs_files[i].name,
+				    S_IRUGO | S_IWUSR,
+				    minor->debugfs_root, minor->dev,
+				    nouveau_debugfs_files[i].fops);
 	}
 
-	ret = drm_debugfs_create_files(nouveau_debugfs_list,
-				       NOUVEAU_DEBUGFS_ENTRIES,
-				       minor->debugfs_root, minor);
-	if (ret)
-		return ret;
+	drm_debugfs_create_files(nouveau_debugfs_list,
+				 NOUVEAU_DEBUGFS_ENTRIES,
+				 minor->debugfs_root, minor);
 
 	/* Set the size of the vbios since we know it, and it's confusing to
 	 * userspace if it wants to seek() but the file has a length of 0
-- 
2.25.0

WARNING: multiple messages have this Message-ID (diff)
From: Wambui Karuga <wambui.karugax@gmail.com>
To: bskeggs@redhat.com, airlied@linux.ie, daniel@ffwll.ch
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org
Subject: [PATCH] drm/nouveau: remove checks for return value of debugfs functions
Date: Tue, 18 Feb 2020 20:28:17 +0300	[thread overview]
Message-ID: <20200218172821.18378-6-wambui.karugax@gmail.com> (raw)
In-Reply-To: <20200218172821.18378-1-wambui.karugax@gmail.com>

As there is no need to check for the return value of debugfs_create_file
and drm_debugfs_create_files, remove unnecessary checks and error
handling in nouveau_drm_debugfs_init.

Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
---
 drivers/gpu/drm/nouveau/nouveau_debugfs.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index 7dfbbbc1beea..15a3d40edf02 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -222,22 +222,18 @@ nouveau_drm_debugfs_init(struct drm_minor *minor)
 {
 	struct nouveau_drm *drm = nouveau_drm(minor->dev);
 	struct dentry *dentry;
-	int i, ret;
+	int i;
 
 	for (i = 0; i < ARRAY_SIZE(nouveau_debugfs_files); i++) {
-		dentry = debugfs_create_file(nouveau_debugfs_files[i].name,
-					     S_IRUGO | S_IWUSR,
-					     minor->debugfs_root, minor->dev,
-					     nouveau_debugfs_files[i].fops);
-		if (!dentry)
-			return -ENOMEM;
+		debugfs_create_file(nouveau_debugfs_files[i].name,
+				    S_IRUGO | S_IWUSR,
+				    minor->debugfs_root, minor->dev,
+				    nouveau_debugfs_files[i].fops);
 	}
 
-	ret = drm_debugfs_create_files(nouveau_debugfs_list,
-				       NOUVEAU_DEBUGFS_ENTRIES,
-				       minor->debugfs_root, minor);
-	if (ret)
-		return ret;
+	drm_debugfs_create_files(nouveau_debugfs_list,
+				 NOUVEAU_DEBUGFS_ENTRIES,
+				 minor->debugfs_root, minor);
 
 	/* Set the size of the vbios since we know it, and it's confusing to
 	 * userspace if it wants to seek() but the file has a length of 0
-- 
2.25.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-02-18 17:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 17:28 [PATCH] drm/arc: make arcpgu_debugfs_init return 0 Wambui Karuga
2020-02-18 17:28 ` Wambui Karuga
2020-02-18 17:28 ` [PATCH] drm/arm: make hdlcd_debugfs_init " Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-24 13:59   ` Liviu Dudau
2020-02-24 13:59     ` Liviu Dudau
2020-02-18 17:28 ` [PATCH 1/2] drm/debugfs: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-18 19:09   ` Daniel Vetter
2020-02-18 19:09     ` Daniel Vetter
2020-02-18 17:28 ` [PATCH] drm/etnaviv: remove check for return value of drm_debugfs function Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-18 17:38   ` Lucas Stach
2020-02-18 17:38     ` Lucas Stach
2020-02-18 18:02     ` Wambui Karuga
2020-02-18 18:02       ` Wambui Karuga
2020-02-18 17:28 ` [PATCH] drm/i915: make i915_debugfs_register return void Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-18 17:28   ` [Intel-gfx] " Wambui Karuga
2020-02-18 17:28 ` Wambui Karuga [this message]
2020-02-18 17:28   ` [PATCH] drm/nouveau: remove checks for return value of debugfs functions Wambui Karuga
     [not found]   ` <20200218172821.18378-6-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-19  5:39     ` Ben Skeggs
2020-02-19  5:39       ` [Nouveau] " Ben Skeggs
2020-02-19  5:39       ` Ben Skeggs
2020-02-18 17:28 ` [PATCH] drm/v3d: make v3d_debugfs_init return 0 Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-19 18:46   ` Eric Anholt
2020-02-19 18:46     ` Eric Anholt
2020-02-18 17:28 ` [PATCH] drm/vc4: remove check of return value of drm_debugfs functions Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-18 17:28 ` [PATCH] drm/vram-helper: make drm_vram_mm_debugfs_init return 0 Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-19  6:00   ` Thomas Zimmermann
2020-02-19  6:00     ` Thomas Zimmermann
2020-02-18 17:28 ` [PATCH 2/2] drm: convert drm_debugfs functions to return void Wambui Karuga
2020-02-18 17:28   ` Wambui Karuga
2020-02-18 18:19 ` [PATCH] drm/arc: make arcpgu_debugfs_init return 0 Greg KH
2020-02-18 18:19   ` Greg KH
2020-02-18 19:00 ` Daniel Vetter
2020-02-18 19:00   ` Daniel Vetter
2020-02-18 19:18   ` Daniel Vetter
2020-02-18 19:18     ` Daniel Vetter
2020-02-19  0:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make i915_debugfs_register return void Patchwork
2020-02-20 13:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218172821.18378-6-wambui.karugax@gmail.com \
    --to=wambui.karugax@gmail.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.