From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: brouer@redhat.com, netdev@vger.kernel.org,
jonathan.lemon@gmail.com, lorenzo@kernel.org, toke@redhat.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Jassi Brar <jaswinder.singh@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v4] net: page_pool: API cleanup and comments
Date: Tue, 18 Feb 2020 18:17:51 +0100 [thread overview]
Message-ID: <20200218181751.1d7139d2@carbon> (raw)
In-Reply-To: <20200218141031.377860-1-ilias.apalodimas@linaro.org>
On Tue, 18 Feb 2020 16:10:31 +0200
Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> Functions starting with __ usually indicate those which are exported,
> but should not be called directly. Update some of those declared in the
> API and make it more readable.
>
> page_pool_unmap_page() and page_pool_release_page() were doing
> exactly the same thing calling __page_pool_clean_page(). Let's
> rename __page_pool_clean_page() to page_pool_release_page() and
> export it in order to show up on perf logs and get rid of
> page_pool_unmap_page().
>
> Finally rename __page_pool_put_page() to page_pool_put_page() since we
> can now directly call it from drivers and rename the existing
> page_pool_put_page() to page_pool_put_full_page() since they do the same
> thing but the latter is trying to sync the full DMA area.
>
> This patch also updates netsec, mvneta and stmmac drivers which use
> those functions.
>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
LGTM - on a quick review (not compile tested...).
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
> Changes since
> v1:
> - Fixed netsec driver compilation error
> v2:
> - Improved comment description of page_pool_put_page()
> v3:
> - Properly define page_pool_release_page() in the header file
> within an ifdef since xdp.c uses it even if CONFIG_PAGE_POOL is not selected
> - rename __page_pool_clean_page -> page_pool_release_page and get rid of
> another redundant helper
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Alexandre Torgue <alexandre.torgue@st.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
toke@redhat.com, John Fastabend <john.fastabend@gmail.com>,
brouer@redhat.com, Alexei Starovoitov <ast@kernel.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Jose Abreu <joabreu@synopsys.com>,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
jonathan.lemon@gmail.com,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
bpf@vger.kernel.org, lorenzo@kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Jesper Dangaard Brouer <hawk@kernel.org>
Subject: Re: [PATCH net-next v4] net: page_pool: API cleanup and comments
Date: Tue, 18 Feb 2020 18:17:51 +0100 [thread overview]
Message-ID: <20200218181751.1d7139d2@carbon> (raw)
In-Reply-To: <20200218141031.377860-1-ilias.apalodimas@linaro.org>
On Tue, 18 Feb 2020 16:10:31 +0200
Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> Functions starting with __ usually indicate those which are exported,
> but should not be called directly. Update some of those declared in the
> API and make it more readable.
>
> page_pool_unmap_page() and page_pool_release_page() were doing
> exactly the same thing calling __page_pool_clean_page(). Let's
> rename __page_pool_clean_page() to page_pool_release_page() and
> export it in order to show up on perf logs and get rid of
> page_pool_unmap_page().
>
> Finally rename __page_pool_put_page() to page_pool_put_page() since we
> can now directly call it from drivers and rename the existing
> page_pool_put_page() to page_pool_put_full_page() since they do the same
> thing but the latter is trying to sync the full DMA area.
>
> This patch also updates netsec, mvneta and stmmac drivers which use
> those functions.
>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
LGTM - on a quick review (not compile tested...).
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
> Changes since
> v1:
> - Fixed netsec driver compilation error
> v2:
> - Improved comment description of page_pool_put_page()
> v3:
> - Properly define page_pool_release_page() in the header file
> within an ifdef since xdp.c uses it even if CONFIG_PAGE_POOL is not selected
> - rename __page_pool_clean_page -> page_pool_release_page and get rid of
> another redundant helper
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-18 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 14:10 [PATCH net-next v4] net: page_pool: API cleanup and comments Ilias Apalodimas
2020-02-18 14:10 ` Ilias Apalodimas
2020-02-18 17:17 ` Jesper Dangaard Brouer [this message]
2020-02-18 17:17 ` Jesper Dangaard Brouer
2020-02-20 0:19 ` David Miller
2020-02-20 0:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218181751.1d7139d2@carbon \
--to=brouer@redhat.com \
--cc=alexandre.torgue@st.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.