From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: clean up lfs/adaptive mount option
Date: Tue, 18 Feb 2020 15:24:13 -0800 [thread overview]
Message-ID: <20200218232413.GA10213@google.com> (raw)
In-Reply-To: <c0436553-a1b6-8124-a096-15d2c3d5bd79@huawei.com>
On 02/17, Chao Yu wrote:
> On 2020/2/15 2:41, Jaegeuk Kim wrote:
> >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >> index 5152e9bf432b..d2d50827772c 100644
> >> --- a/fs/f2fs/f2fs.h
> >> +++ b/fs/f2fs/f2fs.h
> >> @@ -91,8 +91,6 @@ extern const char *f2fs_fault_name[FAULT_MAX];
> >> #define F2FS_MOUNT_FORCE_FG_GC 0x00004000
> >> #define F2FS_MOUNT_DATA_FLUSH 0x00008000
> >> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000
> >> -#define F2FS_MOUNT_ADAPTIVE 0x00020000
> >> -#define F2FS_MOUNT_LFS 0x00040000
> >
> > I don't think we can remove this simply.
> >
> >> #define F2FS_MOUNT_USRQUOTA 0x00080000
> >> #define F2FS_MOUNT_GRPQUOTA 0x00100000
> >> #define F2FS_MOUNT_PRJQUOTA 0x00200000
>
> You mean getting rid of this change or we need to fill F2FS_MOUNT_* hole as below:
nvm. So, we can reuse the removed bits later in other features.
>
> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000
> -#define F2FS_MOUNT_ADAPTIVE 0x00020000
> -#define F2FS_MOUNT_LFS 0x00040000
> +#define F2FS_MOUNT_USRQUOTA 0x00020000
> +#define F2FS_MOUNT_GRPQUOTA 0x00040000
> ...
>
> Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH 3/4] f2fs: clean up lfs/adaptive mount option
Date: Tue, 18 Feb 2020 15:24:13 -0800 [thread overview]
Message-ID: <20200218232413.GA10213@google.com> (raw)
In-Reply-To: <c0436553-a1b6-8124-a096-15d2c3d5bd79@huawei.com>
On 02/17, Chao Yu wrote:
> On 2020/2/15 2:41, Jaegeuk Kim wrote:
> >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >> index 5152e9bf432b..d2d50827772c 100644
> >> --- a/fs/f2fs/f2fs.h
> >> +++ b/fs/f2fs/f2fs.h
> >> @@ -91,8 +91,6 @@ extern const char *f2fs_fault_name[FAULT_MAX];
> >> #define F2FS_MOUNT_FORCE_FG_GC 0x00004000
> >> #define F2FS_MOUNT_DATA_FLUSH 0x00008000
> >> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000
> >> -#define F2FS_MOUNT_ADAPTIVE 0x00020000
> >> -#define F2FS_MOUNT_LFS 0x00040000
> >
> > I don't think we can remove this simply.
> >
> >> #define F2FS_MOUNT_USRQUOTA 0x00080000
> >> #define F2FS_MOUNT_GRPQUOTA 0x00100000
> >> #define F2FS_MOUNT_PRJQUOTA 0x00200000
>
> You mean getting rid of this change or we need to fill F2FS_MOUNT_* hole as below:
nvm. So, we can reuse the removed bits later in other features.
>
> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000
> -#define F2FS_MOUNT_ADAPTIVE 0x00020000
> -#define F2FS_MOUNT_LFS 0x00040000
> +#define F2FS_MOUNT_USRQUOTA 0x00020000
> +#define F2FS_MOUNT_GRPQUOTA 0x00040000
> ...
>
> Thanks,
next prev parent reply other threads:[~2020-02-18 23:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 9:44 [f2fs-dev] [PATCH 1/4] f2fs: clean up codes with {f2fs_, }data_blkaddr() Chao Yu
2020-02-14 9:44 ` [PATCH 1/4] f2fs: clean up codes with {f2fs_,}data_blkaddr() Chao Yu
2020-02-14 9:44 ` [f2fs-dev] [PATCH 2/4] f2fs: clean up parameter of macro XATTR_SIZE() Chao Yu
2020-02-14 9:44 ` Chao Yu
2020-02-14 9:44 ` [f2fs-dev] [PATCH 3/4] f2fs: clean up lfs/adaptive mount option Chao Yu
2020-02-14 9:44 ` Chao Yu
2020-02-14 18:41 ` [f2fs-dev] " Jaegeuk Kim
2020-02-14 18:41 ` Jaegeuk Kim
2020-02-17 1:03 ` [f2fs-dev] " Chao Yu
2020-02-17 1:03 ` Chao Yu
2020-02-18 23:24 ` Jaegeuk Kim [this message]
2020-02-18 23:24 ` Jaegeuk Kim
2020-02-14 9:44 ` [f2fs-dev] [PATCH 4/4] f2fs: clean up bggc " Chao Yu
2020-02-14 9:44 ` Chao Yu
2020-02-14 18:42 ` [f2fs-dev] " Jaegeuk Kim
2020-02-14 18:42 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218232413.GA10213@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.