From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
gustavo@embeddedor.com
Subject: Re: [PATCH] iommu: Use C99 flexible array in fwspec
Date: Wed, 19 Feb 2020 11:16:12 +0100 [thread overview]
Message-ID: <20200219101612.GC1961@8bytes.org> (raw)
In-Reply-To: <7364595699c37d2ef53636c8af6dcefa6602529b.1581601149.git.robin.murphy@arm.com>
On Thu, Feb 13, 2020 at 02:00:21PM +0000, Robin Murphy wrote:
> Although the 1-element array was a typical pre-C99 way to implement
> variable-length structures, and indeed is a fundamental construct in the
> APIs of certain other popular platforms, there's no good reason for it
> here (and in particular the sizeof() trick is far too "clever" for its
> own good). We can just as easily implement iommu_fwspec's preallocation
> behaviour using a standard flexible array member, so let's make it look
> the way most readers would expect.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Before the Coccinelle police catch up with me... :)
Applied, thanks. You should be safe now :)
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, gustavo@embeddedor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: Use C99 flexible array in fwspec
Date: Wed, 19 Feb 2020 11:16:12 +0100 [thread overview]
Message-ID: <20200219101612.GC1961@8bytes.org> (raw)
In-Reply-To: <7364595699c37d2ef53636c8af6dcefa6602529b.1581601149.git.robin.murphy@arm.com>
On Thu, Feb 13, 2020 at 02:00:21PM +0000, Robin Murphy wrote:
> Although the 1-element array was a typical pre-C99 way to implement
> variable-length structures, and indeed is a fundamental construct in the
> APIs of certain other popular platforms, there's no good reason for it
> here (and in particular the sizeof() trick is far too "clever" for its
> own good). We can just as easily implement iommu_fwspec's preallocation
> behaviour using a standard flexible array member, so let's make it look
> the way most readers would expect.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Before the Coccinelle police catch up with me... :)
Applied, thanks. You should be safe now :)
next prev parent reply other threads:[~2020-02-19 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:00 [PATCH] iommu: Use C99 flexible array in fwspec Robin Murphy
2020-02-13 14:00 ` Robin Murphy
2020-02-19 10:16 ` Joerg Roedel [this message]
2020-02-19 10:16 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219101612.GC1961@8bytes.org \
--to=joro@8bytes.org \
--cc=gustavo@embeddedor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.