From: Johannes Weiner <hannes@cmpxchg.org>
To: Kenny Ho <y2kenny@gmail.com>
Cc: juan.zuniga-anaya@amd.com, "Daniel Vetter" <daniel@ffwll.ch>,
"Kenny Ho" <Kenny.Ho@amd.com>,
"Kuehling, Felix" <felix.kuehling@amd.com>,
jsparks@cray.com, nirmoy.das@amd.com,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
lkaplan@cray.com, "Alex Deucher" <alexander.deucher@amd.com>,
"Greathouse, Joseph" <joseph.greathouse@amd.com>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Jason Ekstrand" <jason@jlekstrand.net>,
"Tejun Heo" <tj@kernel.org>,
cgroups@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
damon.mcdougall@amd.com
Subject: Re: [PATCH 09/11] drm, cgroup: Introduce lgpu as DRM cgroup resource
Date: Wed, 19 Feb 2020 11:21:25 -0500 [thread overview]
Message-ID: <20200219162125.GC13406@cmpxchg.org> (raw)
In-Reply-To: <CAOWid-dA2Ad-FTZDDLOs4pperYbsru9cknSuXo_2ajpPbQH0Xg@mail.gmail.com>
On Fri, Feb 14, 2020 at 03:28:40PM -0500, Kenny Ho wrote:
> On Fri, Feb 14, 2020 at 2:17 PM Tejun Heo <tj@kernel.org> wrote:
> > Also, a rather trivial high level question. Is drm a good controller
> > name given that other controller names are like cpu, memory, io?
>
> There was a discussion about naming early in the RFC (I believe
> RFCv2), the consensuses then was to use drmcg to align with the drm
> subsystem. I have no problem renaming it to gpucg or something
> similar if that is the last thing that's blocking acceptance. For
> now, I would like to get some clarity on the implementation before
> having more code churn.
As far as precedence goes, we named the other controllers after the
resources they control rather than the subsystem: cpu instead of
scheduler, memory instead of mm, io instead of block layer etc.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Kenny Ho <y2kenny-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Daniel Vetter" <daniel-/w4YWyX8dFk@public.gmane.org>,
"Jason Ekstrand" <jason-fQELhIk9awXprZlt/sZkLg@public.gmane.org>,
"Kenny Ho" <Kenny.Ho-5C7GfCeVMHo@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Maling list - DRI developers"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"amd-gfx mailing list"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"Alex Deucher" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
"Kuehling, Felix" <felix.kuehling-5C7GfCeVMHo@public.gmane.org>,
"Greathouse,
Joseph" <joseph.greathouse-5C7GfCeVMHo@public.gmane.org>,
jsparks-WVYJKLFxKCc@public.gmane.org,
lkaplan-WVYJKLFxKCc@public.gmane.org,
nirmoy.das-5C7GfCeVMHo@public.gmane.org,
damon.mcdougall-5C7GfCeVMHo@public.gmane.org,
juan.zuniga-anaya-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH 09/11] drm, cgroup: Introduce lgpu as DRM cgroup resource
Date: Wed, 19 Feb 2020 11:21:25 -0500 [thread overview]
Message-ID: <20200219162125.GC13406@cmpxchg.org> (raw)
In-Reply-To: <CAOWid-dA2Ad-FTZDDLOs4pperYbsru9cknSuXo_2ajpPbQH0Xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, Feb 14, 2020 at 03:28:40PM -0500, Kenny Ho wrote:
> On Fri, Feb 14, 2020 at 2:17 PM Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > Also, a rather trivial high level question. Is drm a good controller
> > name given that other controller names are like cpu, memory, io?
>
> There was a discussion about naming early in the RFC (I believe
> RFCv2), the consensuses then was to use drmcg to align with the drm
> subsystem. I have no problem renaming it to gpucg or something
> similar if that is the last thing that's blocking acceptance. For
> now, I would like to get some clarity on the implementation before
> having more code churn.
As far as precedence goes, we named the other controllers after the
resources they control rather than the subsystem: cpu instead of
scheduler, memory instead of mm, io instead of block layer etc.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Kenny Ho <y2kenny@gmail.com>
Cc: juan.zuniga-anaya@amd.com, "Kenny Ho" <Kenny.Ho@amd.com>,
"Kuehling, Felix" <felix.kuehling@amd.com>,
jsparks@cray.com, nirmoy.das@amd.com,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
lkaplan@cray.com, "Alex Deucher" <alexander.deucher@amd.com>,
"Greathouse, Joseph" <joseph.greathouse@amd.com>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Jason Ekstrand" <jason@jlekstrand.net>,
"Tejun Heo" <tj@kernel.org>,
cgroups@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
damon.mcdougall@amd.com
Subject: Re: [PATCH 09/11] drm, cgroup: Introduce lgpu as DRM cgroup resource
Date: Wed, 19 Feb 2020 11:21:25 -0500 [thread overview]
Message-ID: <20200219162125.GC13406@cmpxchg.org> (raw)
In-Reply-To: <CAOWid-dA2Ad-FTZDDLOs4pperYbsru9cknSuXo_2ajpPbQH0Xg@mail.gmail.com>
On Fri, Feb 14, 2020 at 03:28:40PM -0500, Kenny Ho wrote:
> On Fri, Feb 14, 2020 at 2:17 PM Tejun Heo <tj@kernel.org> wrote:
> > Also, a rather trivial high level question. Is drm a good controller
> > name given that other controller names are like cpu, memory, io?
>
> There was a discussion about naming early in the RFC (I believe
> RFCv2), the consensuses then was to use drmcg to align with the drm
> subsystem. I have no problem renaming it to gpucg or something
> similar if that is the last thing that's blocking acceptance. For
> now, I would like to get some clarity on the implementation before
> having more code churn.
As far as precedence goes, we named the other controllers after the
resources they control rather than the subsystem: cpu instead of
scheduler, memory instead of mm, io instead of block layer etc.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-19 16:23 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 15:56 [PATCH 00/11] new cgroup controller for gpu/drm subsystem Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 01/11] cgroup: Introduce cgroup for drm subsystem Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 02/11] drm, cgroup: Bind drm and cgroup subsystem Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 03/11] drm, cgroup: Initialize drmcg properties Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 04/11] drm, cgroup: Add total GEM buffer allocation stats Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 05/11] drm, cgroup: Add peak " Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 06/11] drm, cgroup: Add GEM buffer allocation count stats Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 07/11] drm, cgroup: Add total GEM buffer allocation limit Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 08/11] drm, cgroup: Add peak " Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 09/11] drm, cgroup: Introduce lgpu as DRM cgroup resource Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 16:44 ` Jason Ekstrand
2020-02-14 16:44 ` Jason Ekstrand
2020-02-14 16:44 ` Jason Ekstrand
2020-02-14 16:59 ` Jason Ekstrand
2020-02-14 16:59 ` Jason Ekstrand
2020-02-14 16:59 ` Jason Ekstrand
2020-02-14 17:08 ` Kenny Ho
2020-02-14 17:08 ` Kenny Ho
2020-02-14 17:08 ` Kenny Ho
2020-02-14 17:48 ` Jason Ekstrand
2020-02-14 17:48 ` Jason Ekstrand
2020-02-14 17:48 ` Jason Ekstrand
2020-02-14 18:34 ` Daniel Vetter
2020-02-14 18:34 ` Daniel Vetter
2020-02-14 18:34 ` Daniel Vetter
2020-02-14 18:51 ` Kenny Ho
2020-02-14 18:51 ` Kenny Ho
2020-02-14 18:51 ` Kenny Ho
2020-02-14 19:17 ` Tejun Heo
2020-02-14 19:17 ` Tejun Heo
2020-02-14 19:17 ` Tejun Heo
2020-02-14 20:28 ` Kenny Ho
2020-02-14 20:28 ` Kenny Ho
2020-02-14 20:28 ` Kenny Ho
2020-02-14 21:15 ` Tejun Heo
2020-02-14 21:15 ` Tejun Heo
2020-02-14 21:15 ` Tejun Heo
2020-02-19 16:21 ` Johannes Weiner [this message]
2020-02-19 16:21 ` Johannes Weiner
2020-02-19 16:21 ` Johannes Weiner
2020-02-19 16:18 ` Johannes Weiner
2020-02-19 16:18 ` Johannes Weiner
2020-02-19 16:18 ` Johannes Weiner
2020-02-19 16:28 ` Kenny Ho
2020-02-19 16:28 ` Kenny Ho
2020-02-19 16:28 ` Kenny Ho
2020-02-19 18:38 ` Johannes Weiner
2020-02-19 18:38 ` Johannes Weiner
2020-02-19 18:38 ` Johannes Weiner
2020-02-21 5:59 ` Kenny Ho
2020-02-21 5:59 ` Kenny Ho
2020-02-21 5:59 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 10/11] drm, cgroup: add update trigger after limit change Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` [PATCH 11/11] drm/amdgpu: Integrate with DRM cgroup Kenny Ho
2020-02-14 15:56 ` Kenny Ho
2020-02-14 15:56 ` Kenny Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219162125.GC13406@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=Kenny.Ho@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cgroups@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=damon.mcdougall@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=jason@jlekstrand.net \
--cc=joseph.greathouse@amd.com \
--cc=jsparks@cray.com \
--cc=juan.zuniga-anaya@amd.com \
--cc=lkaplan@cray.com \
--cc=nirmoy.das@amd.com \
--cc=tj@kernel.org \
--cc=y2kenny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.