From: Christoph Hellwig <hch@infradead.org>
To: Coly Li <colyli@suse.de>
Cc: axboe@kernel.dk, linux-bcache@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] bcache: ignore pending signals when creating gc and allocator thread
Date: Wed, 19 Feb 2020 08:32:00 -0800 [thread overview]
Message-ID: <20200219163200.GA18377@infradead.org> (raw)
In-Reply-To: <20200213141207.77219-2-colyli@suse.de>
On Thu, Feb 13, 2020 at 10:12:05PM +0800, Coly Li wrote:
> + /*
> + * In case previous btree check operation occupies too many
> + * system memory for bcache btree node cache, and the
> + * registering process is selected by OOM killer. Here just
> + * ignore the SIGKILL sent by OOM killer if there is, to
> + * avoid kthread_run() being failed by pending signals. The
> + * bcache registering process will exit after the registration
> + * done.
> + */
> + if (signal_pending(current))
> + flush_signals(current);
> +
> + k = kthread_run(bch_allocator_thread, ca, "bcache_allocator");
This really needs to go into the kthread code itself instead of
requiring cargo culting in the callers.
next prev parent reply other threads:[~2020-02-19 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:12 [PATCH 0/3] bcache patches for Linux v5.6-rc2 Coly Li
2020-02-13 14:12 ` [PATCH 1/3] bcache: ignore pending signals when creating gc and allocator thread Coly Li
2020-02-19 16:32 ` Christoph Hellwig [this message]
2020-02-20 13:20 ` Coly Li
2020-02-20 16:38 ` Christoph Hellwig
2020-02-20 16:47 ` Coly Li
2020-02-13 14:12 ` [PATCH 2/3] bcache: Revert "bcache: shrink btree node cache after bch_btree_check()" Coly Li
2020-02-13 14:12 ` [PATCH 3/3] bcache: remove macro nr_to_fifo_front() Coly Li
2020-02-13 15:54 ` [PATCH 0/3] bcache patches for Linux v5.6-rc2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219163200.GA18377@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.