From: Coly Li <colyli@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-bcache@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] bcache: ignore pending signals when creating gc and allocator thread
Date: Fri, 21 Feb 2020 00:47:56 +0800 [thread overview]
Message-ID: <b2f997ce-3b47-19ec-439d-e29a35ff7ef4@suse.de> (raw)
In-Reply-To: <20200220163803.GA12147@infradead.org>
On 2020/2/21 12:38 上午, Christoph Hellwig wrote:
> On Thu, Feb 20, 2020 at 09:20:49PM +0800, Coly Li wrote:
>> Therefore I need to explicitly call pending_signal() before calling
>> kthread_run().
>
> Right now you have to. But the proper fix is to not require this and
> fix kthread_run to work from a thread that has been selected by the OOM
> killer. In the most trivial version by moving your code into
> kthread_run, but there probably are better ways as well.
>
Yes I see. Let me think about it, at this moment kthread_run() is still
not very clear in my mind.
Thanks for the hint.
--
Coly Li
next prev parent reply other threads:[~2020-02-20 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:12 [PATCH 0/3] bcache patches for Linux v5.6-rc2 Coly Li
2020-02-13 14:12 ` [PATCH 1/3] bcache: ignore pending signals when creating gc and allocator thread Coly Li
2020-02-19 16:32 ` Christoph Hellwig
2020-02-20 13:20 ` Coly Li
2020-02-20 16:38 ` Christoph Hellwig
2020-02-20 16:47 ` Coly Li [this message]
2020-02-13 14:12 ` [PATCH 2/3] bcache: Revert "bcache: shrink btree node cache after bch_btree_check()" Coly Li
2020-02-13 14:12 ` [PATCH 3/3] bcache: remove macro nr_to_fifo_front() Coly Li
2020-02-13 15:54 ` [PATCH 0/3] bcache patches for Linux v5.6-rc2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f997ce-3b47-19ec-439d-e29a35ff7ef4@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.