From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, mchehab+huawei@kernel.org,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime@cerno.tech>,
sakari.ailus@linux.intel.com,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: media: csi: Fix clocks description
Date: Wed, 19 Feb 2020 16:15:40 -0600 [thread overview]
Message-ID: <20200219221540.GA2067@bogus> (raw)
In-Reply-To: <20200210100417.78583-2-maxime@cerno.tech>
On Mon, 10 Feb 2020 11:04:17 +0100, Maxime Ripard wrote:
> Commit 1de243b07666 ("media: dt-bindings: media: sun4i-csi: Add compatible
> for CSI1 on A10/A20") introduced support for the CSI1 controller on A10 and
> A20 that unlike CSI0 doesn't have an ISP and therefore only have two
> clocks, the bus and module clocks.
>
> The clocks and clock-names properties have thus been modified to allow
> either two or tree clocks. However, the current list has the ISP clock at
> the second position, which means the bindings expects a list of either
> bus and isp, or bus, isp and mod. The initial intent of the patch was
> obviously to have bus and mod in the former case.
>
> Let's fix the binding so that it validates properly.
>
> Fixes: 1de243b07666 ("media: dt-bindings: media: sun4i-csi: Add compatible for CSI1 on A10/A20")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../media/allwinner,sun4i-a10-csi.yaml | 30 +++++++++++--------
> 1 file changed, 18 insertions(+), 12 deletions(-)
>
Applied, thanks.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <mripard@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Frank Rowand <frowand.list@gmail.com>,
sakari.ailus@linux.intel.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
mchehab+huawei@kernel.org, linux-media@vger.kernel.org,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH 2/2] dt-bindings: media: csi: Fix clocks description
Date: Wed, 19 Feb 2020 16:15:40 -0600 [thread overview]
Message-ID: <20200219221540.GA2067@bogus> (raw)
In-Reply-To: <20200210100417.78583-2-maxime@cerno.tech>
On Mon, 10 Feb 2020 11:04:17 +0100, Maxime Ripard wrote:
> Commit 1de243b07666 ("media: dt-bindings: media: sun4i-csi: Add compatible
> for CSI1 on A10/A20") introduced support for the CSI1 controller on A10 and
> A20 that unlike CSI0 doesn't have an ISP and therefore only have two
> clocks, the bus and module clocks.
>
> The clocks and clock-names properties have thus been modified to allow
> either two or tree clocks. However, the current list has the ISP clock at
> the second position, which means the bindings expects a list of either
> bus and isp, or bus, isp and mod. The initial intent of the patch was
> obviously to have bus and mod in the former case.
>
> Let's fix the binding so that it validates properly.
>
> Fixes: 1de243b07666 ("media: dt-bindings: media: sun4i-csi: Add compatible for CSI1 on A10/A20")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../media/allwinner,sun4i-a10-csi.yaml | 30 +++++++++++--------
> 1 file changed, 18 insertions(+), 12 deletions(-)
>
Applied, thanks.
Rob
next prev parent reply other threads:[~2020-02-19 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:04 [PATCH 1/2] dt-bindings: media: csi: Add interconnects properties Maxime Ripard
2020-02-10 10:04 ` Maxime Ripard
2020-02-10 10:04 ` [PATCH 2/2] dt-bindings: media: csi: Fix clocks description Maxime Ripard
2020-02-10 10:04 ` Maxime Ripard
2020-02-19 22:15 ` Rob Herring [this message]
2020-02-19 22:15 ` Rob Herring
2020-02-19 22:15 ` [PATCH 1/2] dt-bindings: media: csi: Add interconnects properties Rob Herring
2020-02-19 22:15 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219221540.GA2067@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=mchehab+huawei@kernel.org \
--cc=mripard@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.