All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Ren <rentao.bupt@gmail.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 0/5] aspeed-g6: enable usb support
Date: Wed, 19 Feb 2020 17:31:04 -0800	[thread overview]
Message-ID: <20200220013103.GA4830@taoren-ubuntuvm> (raw)
In-Reply-To: <5d295199-d0d7-4d58-be29-4621738d7f28@www.fastmail.com>

On Thu, Feb 20, 2020 at 10:55:10AM +1030, Andrew Jeffery wrote:
> 
> 
> On Tue, 18 Feb 2020, at 13:43, rentao.bupt at gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> > 
> > The patch series aims at enabling USB Host and Gadget support on AST2600
> > platforms.
> > 
> > Patch #1 replaces hardcoded vhub port/endpoint number with device tree
> > properties, so that it's more convenient to add support for ast2600-vhub
> > which provides more downstream ports and endpoints.
> 
> Ah, something I should have mentioned on the previous series is you'll need
> to update the binding documentation with the new properties.

Looks like we don't have dt binding documentation for this driver. I will add
the document in my 2nd patch set "allow to customize vhub device IDs/strings"
so all the new dt properties are included in the doc.

> > 
> > Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.
> 
> Also need to add the 2600 support to the dt binding document.
> 
> Looks good to me otherwise.
> 
> Andrew

Thanks again for the quick review, Andrew.


Cheers,

Tao

WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Joel Stanley <joel@jms.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Colin King <colin.king@canonical.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
	Tao Ren <taoren@fb.com>
Subject: Re: [PATCH v3 0/5] aspeed-g6: enable usb support
Date: Wed, 19 Feb 2020 17:31:04 -0800	[thread overview]
Message-ID: <20200220013103.GA4830@taoren-ubuntuvm> (raw)
In-Reply-To: <5d295199-d0d7-4d58-be29-4621738d7f28@www.fastmail.com>

On Thu, Feb 20, 2020 at 10:55:10AM +1030, Andrew Jeffery wrote:
> 
> 
> On Tue, 18 Feb 2020, at 13:43, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> > 
> > The patch series aims at enabling USB Host and Gadget support on AST2600
> > platforms.
> > 
> > Patch #1 replaces hardcoded vhub port/endpoint number with device tree
> > properties, so that it's more convenient to add support for ast2600-vhub
> > which provides more downstream ports and endpoints.
> 
> Ah, something I should have mentioned on the previous series is you'll need
> to update the binding documentation with the new properties.

Looks like we don't have dt binding documentation for this driver. I will add
the document in my 2nd patch set "allow to customize vhub device IDs/strings"
so all the new dt properties are included in the doc.

> > 
> > Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.
> 
> Also need to add the 2600 support to the dt binding document.
> 
> Looks good to me otherwise.
> 
> Andrew

Thanks again for the quick review, Andrew.


Cheers,

Tao

WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Felipe Balbi <balbi@kernel.org>,
	linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org,
	Tao Ren <taoren@fb.com>,
	linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Colin King <colin.king@canonical.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] aspeed-g6: enable usb support
Date: Wed, 19 Feb 2020 17:31:04 -0800	[thread overview]
Message-ID: <20200220013103.GA4830@taoren-ubuntuvm> (raw)
In-Reply-To: <5d295199-d0d7-4d58-be29-4621738d7f28@www.fastmail.com>

On Thu, Feb 20, 2020 at 10:55:10AM +1030, Andrew Jeffery wrote:
> 
> 
> On Tue, 18 Feb 2020, at 13:43, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> > 
> > The patch series aims at enabling USB Host and Gadget support on AST2600
> > platforms.
> > 
> > Patch #1 replaces hardcoded vhub port/endpoint number with device tree
> > properties, so that it's more convenient to add support for ast2600-vhub
> > which provides more downstream ports and endpoints.
> 
> Ah, something I should have mentioned on the previous series is you'll need
> to update the binding documentation with the new properties.

Looks like we don't have dt binding documentation for this driver. I will add
the document in my 2nd patch set "allow to customize vhub device IDs/strings"
so all the new dt properties are included in the doc.

> > 
> > Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.
> 
> Also need to add the 2600 support to the dt binding document.
> 
> Looks good to me otherwise.
> 
> Andrew

Thanks again for the quick review, Andrew.


Cheers,

Tao

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-20  1:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18  3:13 [PATCH v3 0/5] aspeed-g6: enable usb support rentao.bupt
2020-02-18  3:13 ` rentao.bupt
2020-02-18  3:13 ` rentao.bupt
2020-02-18  3:13 ` [PATCH v3 1/5] usb: gadget: aspeed: read vhub properties from device tree rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13 ` [PATCH v3 2/5] usb: gadget: aspeed: add ast2600 vhub support rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13 ` [PATCH v3 3/5] ARM: dts: aspeed-g6: add usb functions rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13 ` [PATCH v3 4/5] ARM: dts: aspeed-g5: add vhub port and endpoint properties rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13 ` [PATCH v3 5/5] ARM: dts: aspeed-g4: " rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-18  3:13   ` rentao.bupt
2020-02-20  0:25 ` [PATCH v3 0/5] aspeed-g6: enable usb support Andrew Jeffery
2020-02-20  0:25   ` Andrew Jeffery
2020-02-20  0:25   ` Andrew Jeffery
2020-02-20  1:31   ` Tao Ren [this message]
2020-02-20  1:31     ` Tao Ren
2020-02-20  1:31     ` Tao Ren
2020-02-21  0:27 ` Tao Ren
2020-02-21  0:27   ` Tao Ren
2020-02-21  0:27   ` Tao Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220013103.GA4830@taoren-ubuntuvm \
    --to=rentao.bupt@gmail.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.