All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Turner <mattst88@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Mike Gilbert <floppym@gentoo.org>
Subject: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed
Date: Wed, 19 Feb 2020 22:51:42 -0800	[thread overview]
Message-ID: <20200220065142.869129-2-mattst88@gmail.com> (raw)
In-Reply-To: <20200220065142.869129-1-mattst88@gmail.com>

From: Mike Gilbert <floppym@gentoo.org>

PIE should be disabled in assembly sources as well, or else grub will
fail to boot.

Bug: https://bugs.gentoo.org/667852
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index b5e31c787..e2c783652 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1263,6 +1263,7 @@ grub_CHECK_LINK_PIE
 # `-fPIE' or '-fpie' and '-pie' in the default specs.
 if [ x"$pie_possible" = xyes ]; then
   TARGET_CFLAGS="$TARGET_CFLAGS -fno-PIE -fno-pie"
+  TARGET_CCASFLAGS="$TARGET_CCASFLAGS -fno-PIE -fno-pie"
 fi
 
 if [ x"$link_nopie_needed" = xyes ] || [ x"$pie_possible" = xyes ]; then
-- 
2.24.1



  reply	other threads:[~2020-02-20  6:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  6:51 [PATCH 1/2] build: Move TARGET_* assignments earlier Matt Turner
2020-02-20  6:51 ` Matt Turner [this message]
2020-02-20 16:16   ` [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed John Paul Adrian Glaubitz
2020-02-23 14:26   ` John Paul Adrian Glaubitz
2020-02-25 10:58   ` Paul Menzel
2020-02-25 11:02     ` John Paul Adrian Glaubitz
2020-02-21 12:14 ` [PATCH 1/2] build: Move TARGET_* assignments earlier Daniel Kiper
2020-02-23 14:28 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220065142.869129-2-mattst88@gmail.com \
    --to=mattst88@gmail.com \
    --cc=floppym@gentoo.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.