* [Intel-gfx] [PATCH] drm/i915: remove the other slab_dependencies @ 2020-02-20 10:57 Matthew Auld 2020-02-20 11:00 ` Chris Wilson 2020-02-20 12:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Matthew Auld @ 2020-02-20 10:57 UTC (permalink / raw) To: intel-gfx The real one can be found in i915_scheduler.c. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_request.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 6daf18dbb3d4..dbd882fe22ef 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -51,7 +51,6 @@ struct execute_cb { static struct i915_global_request { struct i915_global base; struct kmem_cache *slab_requests; - struct kmem_cache *slab_dependencies; struct kmem_cache *slab_execute_cbs; } global; @@ -1614,14 +1613,12 @@ long i915_request_wait(struct i915_request *rq, static void i915_global_request_shrink(void) { - kmem_cache_shrink(global.slab_dependencies); kmem_cache_shrink(global.slab_execute_cbs); kmem_cache_shrink(global.slab_requests); } static void i915_global_request_exit(void) { - kmem_cache_destroy(global.slab_dependencies); kmem_cache_destroy(global.slab_execute_cbs); kmem_cache_destroy(global.slab_requests); } @@ -1651,16 +1648,9 @@ int __init i915_global_request_init(void) if (!global.slab_execute_cbs) goto err_requests; - global.slab_dependencies = KMEM_CACHE(i915_dependency, - SLAB_HWCACHE_ALIGN | - SLAB_RECLAIM_ACCOUNT); - if (!global.slab_dependencies) - goto err_execute_cbs; - i915_global_register(&global.base); return 0; -err_execute_cbs: kmem_cache_destroy(global.slab_execute_cbs); err_requests: kmem_cache_destroy(global.slab_requests); -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: remove the other slab_dependencies 2020-02-20 10:57 [Intel-gfx] [PATCH] drm/i915: remove the other slab_dependencies Matthew Auld @ 2020-02-20 11:00 ` Chris Wilson 2020-02-20 12:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Chris Wilson @ 2020-02-20 11:00 UTC (permalink / raw) To: Matthew Auld, intel-gfx Quoting Matthew Auld (2020-02-20 10:57:07) > The real one can be found in i915_scheduler.c. > > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> You're not a fan of redundancy, I see :) Oops, Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove the other slab_dependencies 2020-02-20 10:57 [Intel-gfx] [PATCH] drm/i915: remove the other slab_dependencies Matthew Auld 2020-02-20 11:00 ` Chris Wilson @ 2020-02-20 12:10 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2020-02-20 12:10 UTC (permalink / raw) To: Matthew Auld; +Cc: intel-gfx == Series Details == Series: drm/i915: remove the other slab_dependencies URL : https://patchwork.freedesktop.org/series/73701/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7972 -> Patchwork_16643 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_16643 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_16643, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_16643: ### IGT changes ### #### Possible regressions #### * igt@prime_busy@basic-wait-before-default: - fi-skl-6770hq: NOTRUN -> [DMESG-WARN][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-skl-6770hq/igt@prime_busy@basic-wait-before-default.html Known issues ------------ Here are the changes found in Patchwork_16643 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-hsw-peppy: [PASS][2] -> [INCOMPLETE][3] ([i915#694] / [i915#816]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-hsw-peppy/igt@gem_close_race@basic-threads.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-hsw-peppy/igt@gem_close_race@basic-threads.html * igt@i915_selftest@live_gem_contexts: - fi-cml-s: [PASS][4] -> [DMESG-FAIL][5] ([i915#877]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-cml-s/igt@i915_selftest@live_gem_contexts.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-cml-s/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_gtt: - fi-bxt-dsi: [PASS][6] -> [TIMEOUT][7] ([fdo#112271]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-bxt-dsi/igt@i915_selftest@live_gtt.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-bxt-dsi/igt@i915_selftest@live_gtt.html - fi-bdw-5557u: [PASS][8] -> [TIMEOUT][9] ([fdo#112271]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-bdw-5557u/igt@i915_selftest@live_gtt.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-bdw-5557u/igt@i915_selftest@live_gtt.html * igt@kms_chamelium@dp-crc-fast: - fi-cml-u2: [PASS][10] -> [FAIL][11] ([i915#262]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html #### Possible fixes #### * igt@i915_module_load@reload: - fi-icl-u3: [DMESG-WARN][12] ([i915#585]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-icl-u3/igt@i915_module_load@reload.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-icl-u3/igt@i915_module_load@reload.html * igt@i915_selftest@live_execlists: - fi-icl-y: [DMESG-FAIL][14] ([fdo#108569]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-icl-y/igt@i915_selftest@live_execlists.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-icl-y/igt@i915_selftest@live_execlists.html * igt@i915_selftest@live_gem_contexts: - fi-cfl-guc: [DMESG-FAIL][16] ([i915#730]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_gtt: - fi-kbl-7500u: [TIMEOUT][18] ([fdo#112271]) -> [PASS][19] [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-kbl-7500u/igt@i915_selftest@live_gtt.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-kbl-7500u/igt@i915_selftest@live_gtt.html * igt@i915_selftest@live_hangcheck: - fi-icl-u3: [INCOMPLETE][20] ([fdo#108569]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7972/fi-icl-u3/igt@i915_selftest@live_hangcheck.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/fi-icl-u3/igt@i915_selftest@live_hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233 [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262 [i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730 [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816 [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877 Participating hosts (50 -> 43) ------------------------------ Additional (2): fi-skl-6770hq fi-gdg-551 Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-bsw-kefka fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7972 -> Patchwork_16643 CI-20190529: 20190529 CI_DRM_7972: 858e6dfae5d9f401678831159b994d197b121e7c @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5453: cae9a5881ed2c5be2c2518a255740b612a927f9a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16643: eeb9d92e0efc49dd9f6cb222ad8566c2a75c3613 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == eeb9d92e0efc drm/i915: remove the other slab_dependencies == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16643/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-20 12:10 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-20 10:57 [Intel-gfx] [PATCH] drm/i915: remove the other slab_dependencies Matthew Auld 2020-02-20 11:00 ` Chris Wilson 2020-02-20 12:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.