From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>
Subject: Re: [PATCH 1/2] ufshcd: remove unused quirks
Date: Thu, 20 Feb 2020 18:24:30 +0100 [thread overview]
Message-ID: <20200220172430.GB14530@lst.de> (raw)
In-Reply-To: <20200219003056.GA213946@gmail.com>
On Tue, Feb 18, 2020 at 04:30:56PM -0800, Eric Biggers wrote:
> On Tue, Feb 18, 2020 at 03:44:49PM -0800, Christoph Hellwig wrote:
> > static inline void ufshcd_utrl_clear(struct ufs_hba *hba, u32 pos)
> > {
> > - if (hba->quirks & UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR)
> > - ufshcd_writel(hba, (1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR);
> > - else
> > - ufshcd_writel(hba, ~(1 << pos),
> > - REG_UTP_TRANSFER_REQ_LIST_CLEAR);
> > + ufshcd_writel(hba, (1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR);
> > }
>
> This part is keeping the quirk version. It needs to be other way around.
Fixed.
next prev parent reply other threads:[~2020-02-20 17:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 23:44 ufshcd quirk cleanup Christoph Hellwig
2020-02-18 23:44 ` [PATCH 1/2] ufshcd: remove unused quirks Christoph Hellwig
2020-02-18 23:58 ` Kiwoong Kim
2020-02-19 0:00 ` Kiwoong Kim
2020-02-19 0:42 ` Eric Biggers
2020-02-19 1:01 ` Alim Akhtar
2020-02-20 17:23 ` 'Christoph Hellwig'
2020-02-19 0:30 ` Eric Biggers
2020-02-20 17:24 ` Christoph Hellwig [this message]
2020-02-18 23:44 ` [PATCH 2/2] ufshcd: use an enum for quirks Christoph Hellwig
2020-02-19 0:10 ` Bart Van Assche
2020-02-20 17:25 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-02-21 14:08 ufshcd quirk cleanup v2 Christoph Hellwig
2020-02-21 14:08 ` [PATCH 1/2] ufshcd: remove unused quirks Christoph Hellwig
2020-02-22 2:46 ` Bart Van Assche
2020-02-22 3:05 ` Alim Akhtar
2020-02-22 12:55 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220172430.GB14530@lst.de \
--to=hch@lst.de \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=ebiggers@kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.