From: Eric Biggers <ebiggers@kernel.org>
To: Kiwoong Kim <kwmad.kim@samsung.com>
Cc: 'Christoph Hellwig' <hch@lst.de>,
linux-scsi@vger.kernel.org,
'Alim Akhtar' <alim.akhtar@samsung.com>,
'Avri Altman' <avri.altman@wdc.com>
Subject: Re: [PATCH 1/2] ufshcd: remove unused quirks
Date: Tue, 18 Feb 2020 16:42:49 -0800 [thread overview]
Message-ID: <20200219004248.GB213946@gmail.com> (raw)
In-Reply-To: <0afd01d5e6b7$988cddf0$c9a699d0$@samsung.com>
On Wed, Feb 19, 2020 at 09:00:26AM +0900, Kiwoong Kim wrote:
>
> Exynos specific driver sets and is using the following quirks but the driver
> is not updated
> yet. I'll do upstream it in the future.
> - UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR
> - UFSHCD_QUIRK_PRDT_BYTE_GRAN
> - UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR
These quirks have been there for 2-3 years without the driver that needs them
even being posted to the mailing list since 2017. Since we don't keep unused
code in the upstream kernel, I support the removal of these quirks. If you
don't want them to be removed, you need to get your driver upstream.
- Eric
next prev parent reply other threads:[~2020-02-19 0:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 23:44 ufshcd quirk cleanup Christoph Hellwig
2020-02-18 23:44 ` [PATCH 1/2] ufshcd: remove unused quirks Christoph Hellwig
2020-02-18 23:58 ` Kiwoong Kim
2020-02-19 0:00 ` Kiwoong Kim
2020-02-19 0:42 ` Eric Biggers [this message]
2020-02-19 1:01 ` Alim Akhtar
2020-02-20 17:23 ` 'Christoph Hellwig'
2020-02-19 0:30 ` Eric Biggers
2020-02-20 17:24 ` Christoph Hellwig
2020-02-18 23:44 ` [PATCH 2/2] ufshcd: use an enum for quirks Christoph Hellwig
2020-02-19 0:10 ` Bart Van Assche
2020-02-20 17:25 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-02-21 14:08 ufshcd quirk cleanup v2 Christoph Hellwig
2020-02-21 14:08 ` [PATCH 1/2] ufshcd: remove unused quirks Christoph Hellwig
2020-02-22 2:46 ` Bart Van Assche
2020-02-22 3:05 ` Alim Akhtar
2020-02-22 12:55 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219004248.GB213946@gmail.com \
--to=ebiggers@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=hch@lst.de \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.