From: Rob Herring <robh@kernel.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com,
Sebastian Reichel <sre@kernel.org>,
"GitAuthor: Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Markus Laine <markus.laine@fi.rohmeurope.com>,
Mikko Mutanen <mikko.mutanen@fi.rohmeurope.com>
Subject: Re: [RFC PATCH v3 2/8] dt_bindings: ROHM BD99954 Charger
Date: Thu, 20 Feb 2020 14:34:44 -0600 [thread overview]
Message-ID: <20200220203444.GA13946@bogus> (raw)
In-Reply-To: <f82f140cd758d435a1ab4e45fef4e17a5af2db5c.1582182989.git.matti.vaittinen@fi.rohmeurope.com>
On Thu, 20 Feb 2020 09:35:10 +0200, Matti Vaittinen wrote:
> The ROHM BD99954 is a Battery Management LSI for 1-4 cell Lithium-Ion
> secondary battery. Intended to be used in space-constraint equipment such
> as Low profile Notebook PC, Tablets and other applications. BD99954
> provides a Dual-source Battery Charger, two port BC1.2 detection and a
> Battery Monitor.
>
> Document the DT bindings for BD99954
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> .../bindings/power/supply/rohm,bd9995x.yaml | 153 ++++++++++++++++++
> 1 file changed, 153 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/rohm,bd9995x.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dts:21.17-29: Warning (reg_format): /example-0/i2c/charger@9:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dts:17.5-28.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dts:17.5-28.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dts:18.23-27.15: Warning (avoid_default_addr_size): /example-0/i2c/charger@9: Relying on default #address-cells value
Documentation/devicetree/bindings/power/supply/rohm,bd9995x.example.dts:18.23-27.15: Warning (avoid_default_addr_size): /example-0/i2c/charger@9: Relying on default #size-cells value
See https://patchwork.ozlabs.org/patch/1241291
Please check and re-submit.
next prev parent reply other threads:[~2020-02-20 20:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 7:33 [RFC PATCH v3 0/8] Support ROHM BD99954 charger IC Matti Vaittinen
2020-02-20 7:33 ` Matti Vaittinen
2020-02-20 7:33 ` Matti Vaittinen
2020-02-20 7:34 ` [RFC PATCH v3 1/8] dt-bindings: battry: add new battery parameters Matti Vaittinen
2020-02-20 7:35 ` [RFC PATCH v3 2/8] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-02-20 20:34 ` Rob Herring [this message]
2020-02-20 7:35 ` [RFC PATCH v3 3/8] drivers: base: add linear ranges helpers Matti Vaittinen
2020-02-20 7:47 ` Randy Dunlap
2020-02-20 8:34 ` Vaittinen, Matti
2020-02-20 7:36 ` [RFC PATCH v3 4/8] regulator: rename regulator_linear_range to linear_range Matti Vaittinen
2020-02-20 7:36 ` Matti Vaittinen
2020-02-20 7:36 ` Matti Vaittinen
2020-02-24 11:53 ` Mark Brown
2020-02-24 11:53 ` Mark Brown
2020-02-24 11:53 ` Mark Brown
2020-02-24 12:20 ` Vaittinen, Matti
2020-02-24 12:20 ` Vaittinen, Matti
2020-02-24 12:20 ` Vaittinen, Matti
2020-02-20 7:36 ` [RFC PATCH v3 5/8] regulator: use linear_ranges helper Matti Vaittinen
2020-02-24 11:57 ` Mark Brown
2020-02-25 6:23 ` Vaittinen, Matti
2020-02-25 15:33 ` Mark Brown
2020-03-03 8:04 ` Vaittinen, Matti
2020-02-20 7:37 ` [RFC PATCH v3 6/8] power: supply: bd70528: use linear ranges Matti Vaittinen
2020-02-20 7:37 ` [RFC PATCH v3 7/8] power: supply: add battery parameters Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220203444.GA13946@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markus.laine@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.