From: Masami Hiramatsu <mhiramat@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Namhyung Kim <namhyung@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Bird <Tim.Bird@sony.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [for-next][PATCH 12/26] Documentation: bootconfig: Add a doc for extended boot config
Date: Thu, 20 Feb 2020 13:13:40 +0000 [thread overview]
Message-ID: <20200220221340.2b66fd2051a5da74775c474b@kernel.org> (raw)
In-Reply-To: <23e371ca-5df8-3ae3-c685-b01c07b55540@web.de>
Hi,
On Thu, 20 Feb 2020 10:10:20 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:
> I wonder about a few details in the added text.
>
>
> …
> > +++ b/Documentation/admin-guide/bootconfig.rst
> …
> > +C onfig File Limitation
>
> How do you think about to omit a space character at the beginning
> of this line?
That was my mistake. I used restructured text extension for vim
which collapsed all sections and use "space" key to expand.
Accidentally, I run into edit mode and hit "space" to expand it.
(it actually expanded but also put a space there and I missed it...)
Anyway, it has been fixed (pointed by Rundy)
> > +Currently the maximum config size size is 32KB …
>
> Would you like to avoid a word duplication here?
Oops, still exist. Thanks!
> > +Note: this is not the number of entries but nodes, an entry must consume
> > +more than 2 nodes (a key-word and a value). …
>
> I find the relevance of the term “nodes” unclear at the moment.
Indeed, "node" is not well defined. What about this?
---
Each key consists of words separated by dot, and value also consists of
values separated by comma. Here, each word and each value is generally
called a "node".
---
>
> Could an other wording be nicer than the abbreviation “a doc for … config”
> in the commit subject?
OK, I'll try next time.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Namhyung Kim <namhyung@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Bird <Tim.Bird@sony.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [for-next][PATCH 12/26] Documentation: bootconfig: Add a doc for extended boot config
Date: Thu, 20 Feb 2020 22:13:40 +0900 [thread overview]
Message-ID: <20200220221340.2b66fd2051a5da74775c474b@kernel.org> (raw)
In-Reply-To: <23e371ca-5df8-3ae3-c685-b01c07b55540@web.de>
Hi,
On Thu, 20 Feb 2020 10:10:20 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:
> I wonder about a few details in the added text.
>
>
> …
> > +++ b/Documentation/admin-guide/bootconfig.rst
> …
> > +C onfig File Limitation
>
> How do you think about to omit a space character at the beginning
> of this line?
That was my mistake. I used restructured text extension for vim
which collapsed all sections and use "space" key to expand.
Accidentally, I run into edit mode and hit "space" to expand it.
(it actually expanded but also put a space there and I missed it...)
Anyway, it has been fixed (pointed by Rundy)
> > +Currently the maximum config size size is 32KB …
>
> Would you like to avoid a word duplication here?
Oops, still exist. Thanks!
> > +Note: this is not the number of entries but nodes, an entry must consume
> > +more than 2 nodes (a key-word and a value). …
>
> I find the relevance of the term “nodes” unclear at the moment.
Indeed, "node" is not well defined. What about this?
---
Each key consists of words separated by dot, and value also consists of
values separated by comma. Here, each word and each value is generally
called a "node".
---
>
> Could an other wording be nicer than the abbreviation “a doc for … config”
> in the commit subject?
OK, I'll try next time.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-02-20 13:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 9:10 [for-next][PATCH 12/26] Documentation: bootconfig: Add a doc for extended boot config Markus Elfring
2020-02-20 9:10 ` Markus Elfring
2020-02-20 13:13 ` Masami Hiramatsu [this message]
2020-02-20 13:13 ` Masami Hiramatsu
2020-02-20 15:00 ` Markus Elfring
2020-02-20 15:00 ` Markus Elfring
2020-02-21 10:16 ` Masami Hiramatsu
2020-02-21 10:16 ` Masami Hiramatsu
2020-02-21 16:43 ` [for-next][12/26] " Markus Elfring
2020-02-21 16:43 ` Markus Elfring
2020-02-22 4:18 ` Masami Hiramatsu
2020-02-22 4:18 ` Masami Hiramatsu
2020-02-22 9:48 ` Markus Elfring
2020-02-22 9:48 ` Markus Elfring
2020-02-22 15:56 ` Masami Hiramatsu
2020-02-22 15:56 ` Masami Hiramatsu
2020-02-22 16:15 ` Markus Elfring
2020-02-22 16:15 ` Markus Elfring
2020-02-24 3:13 ` Masami Hiramatsu
2020-02-24 3:13 ` Masami Hiramatsu
2020-02-24 10:00 ` Markus Elfring
2020-02-24 10:00 ` Markus Elfring
2020-02-25 6:49 ` Masami Hiramatsu
2020-02-25 6:49 ` Masami Hiramatsu
2020-02-25 7:56 ` Markus Elfring
2020-02-25 7:56 ` Markus Elfring
2020-02-25 10:29 ` Masami Hiramatsu
2020-02-25 10:29 ` Masami Hiramatsu
2020-02-25 11:10 ` Markus Elfring
2020-02-25 11:10 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-01-14 21:03 [for-next][PATCH 00/26] tracing: Updates for 5.6 Steven Rostedt
2020-01-14 21:03 ` [for-next][PATCH 12/26] Documentation: bootconfig: Add a doc for extended boot config Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220221340.2b66fd2051a5da74775c474b@kernel.org \
--to=mhiramat@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=Tim.Bird@sony.com \
--cc=acme@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolsa@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.