From: Sam Ravnborg <sam@ravnborg.org>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: mark.rutland@arm.com, baolin.wang@linaro.org, airlied@linux.ie,
zhang.lyra@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
orsonzhai@gmail.com
Subject: Re: [PATCH RFC v3 1/6] dt-bindings: display: add Unisoc's drm master bindings
Date: Fri, 21 Feb 2020 22:21:18 +0100 [thread overview]
Message-ID: <20200221212118.GC3456@ravnborg.org> (raw)
In-Reply-To: <1582271336-3708-2-git-send-email-kevin3.tang@gmail.com>
Hi Kevin.
On Fri, Feb 21, 2020 at 03:48:51PM +0800, Kevin Tang wrote:
> From: Kevin Tang <kevin.tang@unisoc.com>
>
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
> .../devicetree/bindings/display/sprd/drm.yaml | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml
> new file mode 100644
> index 0000000..1614ca6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sprd/drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc DRM master device
> +
> +maintainers:
> + - David Airlie <airlied@linux.ie>
> + - Daniel Vetter <daniel@ffwll.ch>
> + - Rob Herring <robh+dt@kernel.org>
> + - Mark Rutland <mark.rutland@arm.com>
Rob is king of a super-maintainer.
He should not be listed unless he has special
relations to sprd.
David + Daniel - likewise. Unless they are closely related to sprd drop
them.
> +
> +description: |
> + The Unisoc DRM master device is a virtual device needed to list all
> + DPU devices or other display interface nodes that comprise the
> + graphics subsystem.
I wonder why you name it "Unisoc" when all other places references sprd.
> +
> +properties:
> + compatible:
> + const: sprd,display-subsystem
> +
> + ports:
> + description:
> + Should contain a list of phandles pointing to display interface port
> + of DPU devices.
> +
> +required:
> + - compatible
> + - ports
So you want to force the driver to support ports - and no panel
referenced directly?
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "sprd,display-subsystem";
> + ports = <&dpu_out>;
> + };
> \ No newline at end of file
Please fix.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org,
mark.rutland@arm.com, orsonzhai@gmail.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
zhang.lyra@gmail.com, baolin.wang@linaro.org
Subject: Re: [PATCH RFC v3 1/6] dt-bindings: display: add Unisoc's drm master bindings
Date: Fri, 21 Feb 2020 22:21:18 +0100 [thread overview]
Message-ID: <20200221212118.GC3456@ravnborg.org> (raw)
In-Reply-To: <1582271336-3708-2-git-send-email-kevin3.tang@gmail.com>
Hi Kevin.
On Fri, Feb 21, 2020 at 03:48:51PM +0800, Kevin Tang wrote:
> From: Kevin Tang <kevin.tang@unisoc.com>
>
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
> .../devicetree/bindings/display/sprd/drm.yaml | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/sprd/drm.yaml b/Documentation/devicetree/bindings/display/sprd/drm.yaml
> new file mode 100644
> index 0000000..1614ca6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sprd/drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc DRM master device
> +
> +maintainers:
> + - David Airlie <airlied@linux.ie>
> + - Daniel Vetter <daniel@ffwll.ch>
> + - Rob Herring <robh+dt@kernel.org>
> + - Mark Rutland <mark.rutland@arm.com>
Rob is king of a super-maintainer.
He should not be listed unless he has special
relations to sprd.
David + Daniel - likewise. Unless they are closely related to sprd drop
them.
> +
> +description: |
> + The Unisoc DRM master device is a virtual device needed to list all
> + DPU devices or other display interface nodes that comprise the
> + graphics subsystem.
I wonder why you name it "Unisoc" when all other places references sprd.
> +
> +properties:
> + compatible:
> + const: sprd,display-subsystem
> +
> + ports:
> + description:
> + Should contain a list of phandles pointing to display interface port
> + of DPU devices.
> +
> +required:
> + - compatible
> + - ports
So you want to force the driver to support ports - and no panel
referenced directly?
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "sprd,display-subsystem";
> + ports = <&dpu_out>;
> + };
> \ No newline at end of file
Please fix.
Sam
next prev parent reply other threads:[~2020-02-21 21:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 7:48 [PATCH RFC v3 0/6] Add Unisoc's drm kms module Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-21 7:48 ` [PATCH RFC v3 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-21 21:21 ` Sam Ravnborg [this message]
2020-02-21 21:21 ` Sam Ravnborg
2020-02-22 9:10 ` Orson Zhai
2020-02-22 9:10 ` Orson Zhai
2020-02-22 10:49 ` Sam Ravnborg
2020-02-22 10:49 ` Sam Ravnborg
2020-02-22 12:40 ` tang pengchuan
2020-02-21 7:48 ` [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-21 21:36 ` Sam Ravnborg
2020-02-21 21:36 ` Sam Ravnborg
2020-02-22 17:06 ` tang pengchuan
2020-02-22 21:27 ` Sam Ravnborg
2020-02-22 21:27 ` Sam Ravnborg
2020-02-23 4:26 ` tang pengchuan
2020-02-23 4:58 ` tang pengchuan
2020-02-25 7:38 ` Thomas Zimmermann
2020-02-25 7:38 ` Thomas Zimmermann
2020-02-25 9:45 ` tang pengchuan
2020-02-24 16:43 ` Emil Velikov
2020-02-24 16:43 ` Emil Velikov
2020-02-25 3:08 ` tang pengchuan
2020-02-21 7:48 ` [PATCH RFC v3 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-21 21:39 ` Sam Ravnborg
2020-02-21 21:39 ` Sam Ravnborg
2020-02-23 13:46 ` tang pengchuan
2020-02-21 7:48 ` [PATCH RFC v3 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-23 21:38 ` kbuild test robot
2020-02-24 17:35 ` Emil Velikov
2020-02-24 17:35 ` Emil Velikov
2020-02-25 9:08 ` tang pengchuan
2020-02-21 7:48 ` [PATCH RFC v3 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-21 7:48 ` [PATCH RFC v3 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
2020-02-21 7:48 ` Kevin Tang
2020-02-24 0:38 ` kbuild test robot
2020-02-21 21:17 ` [PATCH RFC v3 0/6] Add Unisoc's drm kms module Sam Ravnborg
2020-02-21 21:17 ` Sam Ravnborg
2020-02-23 4:01 ` tang pengchuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221212118.GC3456@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=baolin.wang@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.