From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: peng.fan@nxp.com
Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] remoteproc: imx_rproc: parse early-booted property
Date: Fri, 21 Feb 2020 14:56:05 -0700 [thread overview]
Message-ID: <20200221215605.GC10368@xps15> (raw)
In-Reply-To: <1582097265-20170-6-git-send-email-peng.fan@nxp.com>
On Wed, Feb 19, 2020 at 03:27:41PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> If early-property exists, there is no need to check syscon.
> Just mark early_boot as true.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index b9fabe269fd2..e31ea1090cf3 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -483,7 +483,9 @@ static int imx_rproc_configure_mode(struct imx_rproc *priv)
> int ret;
> u32 val;
>
> - if (of_get_property(dev->of_node, "early-booted", NULL)) {
> + if (dcfg->variants == IMX7ULP) {
Where does dcfg->variants comes from?
This patch doesn't compile, nor does the one before it. I will not review
another patchset like that.
> + priv->early_boot = true;
> + } else if (of_get_property(dev->of_node, "early-booted", NULL)) {
> priv->early_boot = true;
> } else {
> ret = regmap_read(priv->regmap, dcfg->src_reg, &val);
> @@ -509,15 +511,17 @@ static int imx_rproc_probe(struct platform_device *pdev)
> struct rproc *rproc;
> struct regmap_config config = { .name = "imx-rproc" };
> const struct imx_rproc_dcfg *dcfg;
> - struct regmap *regmap;
> + struct regmap *regmap = NULL;
> int ret;
>
> - regmap = syscon_regmap_lookup_by_phandle(np, "syscon");
> - if (IS_ERR(regmap)) {
> - dev_err(dev, "failed to find syscon\n");
> - return PTR_ERR(regmap);
> + if (!of_get_property(np, "early-booted", NULL)) {
> + regmap = syscon_regmap_lookup_by_phandle(np, "syscon");
> + if (IS_ERR(regmap)) {
> + dev_err(dev, "failed to find syscon\n");
> + return PTR_ERR(regmap);
> + }
> + regmap_attach_dev(dev, regmap, &config);
> }
> - regmap_attach_dev(dev, regmap, &config);
>
> /* set some other name then imx */
> rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops,
> --
> 2.16.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: peng.fan@nxp.com
Cc: ohad@wizery.com, devicetree@vger.kernel.org, festevam@gmail.com,
s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/9] remoteproc: imx_rproc: parse early-booted property
Date: Fri, 21 Feb 2020 14:56:05 -0700 [thread overview]
Message-ID: <20200221215605.GC10368@xps15> (raw)
In-Reply-To: <1582097265-20170-6-git-send-email-peng.fan@nxp.com>
On Wed, Feb 19, 2020 at 03:27:41PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> If early-property exists, there is no need to check syscon.
> Just mark early_boot as true.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index b9fabe269fd2..e31ea1090cf3 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -483,7 +483,9 @@ static int imx_rproc_configure_mode(struct imx_rproc *priv)
> int ret;
> u32 val;
>
> - if (of_get_property(dev->of_node, "early-booted", NULL)) {
> + if (dcfg->variants == IMX7ULP) {
Where does dcfg->variants comes from?
This patch doesn't compile, nor does the one before it. I will not review
another patchset like that.
> + priv->early_boot = true;
> + } else if (of_get_property(dev->of_node, "early-booted", NULL)) {
> priv->early_boot = true;
> } else {
> ret = regmap_read(priv->regmap, dcfg->src_reg, &val);
> @@ -509,15 +511,17 @@ static int imx_rproc_probe(struct platform_device *pdev)
> struct rproc *rproc;
> struct regmap_config config = { .name = "imx-rproc" };
> const struct imx_rproc_dcfg *dcfg;
> - struct regmap *regmap;
> + struct regmap *regmap = NULL;
> int ret;
>
> - regmap = syscon_regmap_lookup_by_phandle(np, "syscon");
> - if (IS_ERR(regmap)) {
> - dev_err(dev, "failed to find syscon\n");
> - return PTR_ERR(regmap);
> + if (!of_get_property(np, "early-booted", NULL)) {
> + regmap = syscon_regmap_lookup_by_phandle(np, "syscon");
> + if (IS_ERR(regmap)) {
> + dev_err(dev, "failed to find syscon\n");
> + return PTR_ERR(regmap);
> + }
> + regmap_attach_dev(dev, regmap, &config);
> }
> - regmap_attach_dev(dev, regmap, &config);
>
> /* set some other name then imx */
> rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops,
> --
> 2.16.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-21 21:56 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 7:27 [PATCH 0/9] remoteproc: imx_rproc: support i.MX8/8M/7ULP peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 7:27 ` [PATCH 1/9] dt-bindings: remoteproc: Convert imx-rproc to json-schema peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 14:09 ` Rob Herring
2020-02-19 14:09 ` Rob Herring
2020-02-19 14:09 ` Rob Herring
2020-02-19 14:34 ` Peng Fan
2020-02-19 14:34 ` Peng Fan
2020-02-20 0:37 ` Rob Herring
2020-02-20 0:37 ` Rob Herring
2020-02-19 7:27 ` [PATCH 2/9] dt-bindings: remoteproc: imx-rproc: support i.MX[8,8M,7ULP] peng.fan
2020-02-19 7:27 ` [PATCH 2/9] dt-bindings: remoteproc: imx-rproc: support i.MX[8, 8M, 7ULP] peng.fan
2020-02-19 7:27 ` [PATCH 3/9] remoteproc: add support to skip firmware load when recovery peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 14:39 ` Arnaud POULIQUEN
2020-02-19 14:39 ` Arnaud POULIQUEN
2020-02-19 14:39 ` Arnaud POULIQUEN
2020-02-19 15:40 ` Peng Fan
2020-02-19 15:40 ` Peng Fan
2020-02-20 8:49 ` Arnaud POULIQUEN
2020-02-20 8:49 ` Arnaud POULIQUEN
2020-02-21 18:42 ` Mathieu Poirier
2020-02-21 18:42 ` Mathieu Poirier
2020-02-23 0:01 ` Peng Fan
2020-02-23 0:01 ` Peng Fan
2020-02-19 7:27 ` [PATCH 4/9] remoteproc: imx_rproc: surport early booted remote processor peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-21 21:16 ` Mathieu Poirier
2020-02-21 21:16 ` Mathieu Poirier
2020-02-23 0:05 ` Peng Fan
2020-02-23 0:05 ` Peng Fan
2020-02-19 7:27 ` [PATCH 5/9] remoteproc: imx_rproc: parse early-booted property peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-21 21:56 ` Mathieu Poirier [this message]
2020-02-21 21:56 ` Mathieu Poirier
2020-02-23 0:11 ` Peng Fan
2020-02-23 0:11 ` Peng Fan
2020-02-19 7:27 ` [PATCH 6/9] remoteproc: imx_proc: enable virtio/mailbox peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 7:27 ` [PATCH 7/9] remoteproc: imx_rproc: add i.MX8QM/QXP peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 7:27 ` [PATCH 8/9] remoteproc: imx_rproc: support i.MX7ULP peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 7:27 ` [PATCH 9/9] remoteproc: imx_rproc: add i.MX8MM support peng.fan
2020-02-19 7:27 ` peng.fan
2020-02-19 18:24 ` [PATCH 0/9] remoteproc: imx_rproc: support i.MX8/8M/7ULP Mathieu Poirier
2020-02-19 18:24 ` Mathieu Poirier
2020-02-20 1:36 ` Peng Fan
2020-02-20 1:36 ` Peng Fan
2020-02-20 21:25 ` Mathieu Poirier
2020-02-20 21:25 ` Mathieu Poirier
2020-02-21 1:35 ` Peng Fan
2020-02-21 1:35 ` Peng Fan
2020-02-21 6:51 ` Oleksij Rempel
2020-02-21 6:51 ` Oleksij Rempel
2020-02-21 6:56 ` Peng Fan
2020-02-21 6:56 ` Peng Fan
2020-02-21 7:03 ` Uwe Kleine-König
2020-02-21 7:03 ` Uwe Kleine-König
2020-02-21 7:03 ` Uwe Kleine-König
2020-02-21 7:08 ` Peng Fan
2020-02-21 7:08 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221215605.GC10368@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.