From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Colin King <colin.king@canonical.com>
Cc: devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] staging: speakup: remove redundant initialization of pointer p_key
Date: Sun, 23 Feb 2020 15:58:19 +0000 [thread overview]
Message-ID: <20200223155819.hycmdvrsiid27jeg@function> (raw)
In-Reply-To: <20200223153954.420731-1-colin.king@canonical.com>
Colin King, le dim. 23 févr. 2020 15:39:54 +0000, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer p_key is being initialized with a value that is never read,
> it is assigned a new value later on. The initialization is redundant
> and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed, thanks!
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/keyhelp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c
> index 5f1bda37f86d..822ceac83068 100644
> --- a/drivers/staging/speakup/keyhelp.c
> +++ b/drivers/staging/speakup/keyhelp.c
> @@ -49,7 +49,7 @@ static int cur_item, nstates;
> static void build_key_data(void)
> {
> u_char *kp, counters[MAXFUNCS], ch, ch1;
> - u_short *p_key = key_data, key;
> + u_short *p_key, key;
> int i, offset = 1;
>
> nstates = (int)(state_tbl[-1]);
> --
> 2.25.0
>
--
Samuel
j'etais en train de nettoyer ma souris et le coup est parti...
-+- s sur #ens-mim - et en plus c vrai... -+-
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Colin King <colin.king@canonical.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: remove redundant initialization of pointer p_key
Date: Sun, 23 Feb 2020 16:58:19 +0100 [thread overview]
Message-ID: <20200223155819.hycmdvrsiid27jeg@function> (raw)
In-Reply-To: <20200223153954.420731-1-colin.king@canonical.com>
Colin King, le dim. 23 févr. 2020 15:39:54 +0000, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer p_key is being initialized with a value that is never read,
> it is assigned a new value later on. The initialization is redundant
> and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed, thanks!
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/keyhelp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c
> index 5f1bda37f86d..822ceac83068 100644
> --- a/drivers/staging/speakup/keyhelp.c
> +++ b/drivers/staging/speakup/keyhelp.c
> @@ -49,7 +49,7 @@ static int cur_item, nstates;
> static void build_key_data(void)
> {
> u_char *kp, counters[MAXFUNCS], ch, ch1;
> - u_short *p_key = key_data, key;
> + u_short *p_key, key;
> int i, offset = 1;
>
> nstates = (int)(state_tbl[-1]);
> --
> 2.25.0
>
--
Samuel
j'etais en train de nettoyer ma souris et le coup est parti...
-+- s sur #ens-mim - et en plus c vrai... -+-
next prev parent reply other threads:[~2020-02-23 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 11:26 [PATCH] staging: speakup: remove redundant variable l Colin King
2018-07-11 11:26 ` Colin King
2018-07-11 12:24 ` Samuel Thibault
2018-07-11 12:24 ` Samuel Thibault
2020-02-23 15:39 ` [PATCH] staging: speakup: remove redundant initialization of pointer p_key Colin King
2020-02-23 15:39 ` Colin King
2020-02-23 15:58 ` Samuel Thibault [this message]
2020-02-23 15:58 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200223155819.hycmdvrsiid27jeg@function \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.