From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net v2] net: bridge: fix stale eth hdr pointer in br_dev_xmit
Date: Mon, 24 Feb 2020 08:54:27 -0800 [thread overview]
Message-ID: <20200224085427.0358ed8c@hermes.lan> (raw)
In-Reply-To: <20200224164622.1472051-1-nikolay@cumulusnetworks.com>
On Mon, 24 Feb 2020 18:46:22 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> - eth = eth_hdr(skb);
> skb_pull(skb, ETH_HLEN)
you could just swap these two lines.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net v2] net: bridge: fix stale eth hdr pointer in br_dev_xmit
Date: Mon, 24 Feb 2020 08:54:27 -0800 [thread overview]
Message-ID: <20200224085427.0358ed8c@hermes.lan> (raw)
In-Reply-To: <20200224164622.1472051-1-nikolay@cumulusnetworks.com>
On Mon, 24 Feb 2020 18:46:22 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> - eth = eth_hdr(skb);
> skb_pull(skb, ETH_HLEN)
you could just swap these two lines.
next prev parent reply other threads:[~2020-02-24 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:38 [Bridge] KMSAN: uninit-value in br_dev_xmit syzbot
2020-02-24 8:38 ` syzbot
2020-02-24 8:51 ` [Bridge] " Nikolay Aleksandrov
2020-02-24 8:51 ` Nikolay Aleksandrov
2020-02-24 13:07 ` [Bridge] [PATCH net] net: bridge: fix stale eth hdr pointer " Nikolay Aleksandrov
2020-02-24 13:07 ` Nikolay Aleksandrov
2020-02-24 15:33 ` [Bridge] " Nikolay Aleksandrov
2020-02-24 15:33 ` Nikolay Aleksandrov
2020-02-24 16:46 ` [Bridge] [PATCH net v2] " Nikolay Aleksandrov
2020-02-24 16:46 ` Nikolay Aleksandrov
2020-02-24 16:54 ` Stephen Hemminger [this message]
2020-02-24 16:54 ` Stephen Hemminger
2020-02-24 17:06 ` [Bridge] " nikolay
2020-02-24 17:06 ` nikolay
2020-02-24 19:13 ` [Bridge] " David Miller
2020-02-24 19:13 ` David Miller
2020-02-24 9:47 ` [Bridge] KMSAN: uninit-value " syzbot
2020-02-24 9:47 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224085427.0358ed8c@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.