All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	David Lechner <david@lechnology.com>,
	Tony Lindgren <tony@atomide.com>, Roger Quadros <rogerq@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config
Date: Mon, 24 Feb 2020 10:00:37 +0000	[thread overview]
Message-ID: <20200224100037.GK3494@dell> (raw)
In-Reply-To: <20200127231208.1443-1-s-anna@ti.com>

On Mon, 27 Jan 2020, Suman Anna wrote:

> The DT node full name is currently being used in regmap_config
> which in turn is used to create the regmap debugfs directories.
> This name however is not guaranteed to be unique and the regmap
> debugfs registration can fail in the cases where the syscon nodes
> have the same unit-address but are present in different DT node
> hierarchies. Replace this logic using the syscon reg resource
> address instead (inspired from logic used while creating platform
> devices) to ensure a unique name is given for each syscon.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v2: Fix build warning reported by kbuild test bot
> v1: https://patchwork.kernel.org/patch/11346363/
> 
>  drivers/mfd/syscon.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Waiting for Arnd to review.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: David Lechner <david@lechnology.com>,
	Arnd Bergmann <arnd@arndb.de>, Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config
Date: Mon, 24 Feb 2020 10:00:37 +0000	[thread overview]
Message-ID: <20200224100037.GK3494@dell> (raw)
In-Reply-To: <20200127231208.1443-1-s-anna@ti.com>

On Mon, 27 Jan 2020, Suman Anna wrote:

> The DT node full name is currently being used in regmap_config
> which in turn is used to create the regmap debugfs directories.
> This name however is not guaranteed to be unique and the regmap
> debugfs registration can fail in the cases where the syscon nodes
> have the same unit-address but are present in different DT node
> hierarchies. Replace this logic using the syscon reg resource
> address instead (inspired from logic used while creating platform
> devices) to ensure a unique name is given for each syscon.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v2: Fix build warning reported by kbuild test bot
> v1: https://patchwork.kernel.org/patch/11346363/
> 
>  drivers/mfd/syscon.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Waiting for Arnd to review.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-02-24 10:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 23:12 [PATCH v2] mfd: syscon: Use a unique name with regmap_config Suman Anna
2020-01-27 23:12 ` Suman Anna
2020-01-27 23:12 ` Suman Anna
2020-01-27 23:40 ` David Lechner
2020-01-27 23:40   ` David Lechner
2020-01-28  0:27   ` Suman Anna
2020-01-28  0:27     ` Suman Anna
2020-01-28  0:27     ` Suman Anna
2020-01-30 15:34 ` Andy Shevchenko
2020-01-30 15:34   ` Andy Shevchenko
2020-01-30 17:08   ` Suman Anna
2020-01-30 17:08     ` Suman Anna
2020-01-30 20:43     ` Andy Shevchenko
2020-01-30 20:43       ` Andy Shevchenko
2020-02-24 10:00 ` Lee Jones [this message]
2020-02-24 10:00   ` Lee Jones
2020-03-06  0:29   ` Suman Anna
2020-03-06  0:29     ` Suman Anna
2020-07-24 16:06   ` Lee Jones
2020-07-24 16:06     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224100037.GK3494@dell \
    --to=lee.jones@linaro.org \
    --cc=arnd@arndb.de \
    --cc=david@lechnology.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=s-anna@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.