* [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports
@ 2020-02-24 11:50 ` Michael Walle
0 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2020-02-24 11:50 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo
Cc: Mark Rutland, Michael Walle, Rob Herring, Li Yang
Since commit b9213899d2b0 ("arm64: dts: ls1028a: disable all enetc ports
by default") all the network ports are disabled by default. This makes
sense, but now we have to enable them explicitly in the boards. Do so
for the sl28 module.
Since we are at it. Make sure the second port is only enabled for the
variant 4 of the module. Variant 3 has only one network port.
Signed-off-by: Michael Walle <michael@walle.cc>
---
This patch actually superseeds the following:
https://lore.kernel.org/linux-devicetree/20200220180919.6069-1-michael@walle.cc/
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
index f659e89face8..df212ed5bb94 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
@@ -21,6 +21,7 @@
&enetc_port1 {
phy-handle = <&phy1>;
phy-connection-type = "rgmii-id";
+ status = "okay";
mdio {
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index d221ed471cde..e6ad2f64e64e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -35,6 +35,7 @@
&enetc_port0 {
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
+ status = "okay";
mdio {
#address-cells = <1>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports
@ 2020-02-24 11:50 ` Michael Walle
0 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2020-02-24 11:50 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo
Cc: Mark Rutland, Rob Herring, Li Yang, Michael Walle
Since commit b9213899d2b0 ("arm64: dts: ls1028a: disable all enetc ports
by default") all the network ports are disabled by default. This makes
sense, but now we have to enable them explicitly in the boards. Do so
for the sl28 module.
Since we are at it. Make sure the second port is only enabled for the
variant 4 of the module. Variant 3 has only one network port.
Signed-off-by: Michael Walle <michael@walle.cc>
---
This patch actually superseeds the following:
https://lore.kernel.org/linux-devicetree/20200220180919.6069-1-michael@walle.cc/
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
index f659e89face8..df212ed5bb94 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
@@ -21,6 +21,7 @@
&enetc_port1 {
phy-handle = <&phy1>;
phy-connection-type = "rgmii-id";
+ status = "okay";
mdio {
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index d221ed471cde..e6ad2f64e64e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -35,6 +35,7 @@
&enetc_port0 {
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
+ status = "okay";
mdio {
#address-cells = <1>;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports
2020-02-24 11:50 ` Michael Walle
@ 2020-02-24 11:58 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-02-24 11:58 UTC (permalink / raw)
To: Michael Walle
Cc: Mark Rutland, devicetree, linux-kernel, Li Yang, Rob Herring,
linux-arm-kernel
On Mon, Feb 24, 2020 at 12:50:52PM +0100, Michael Walle wrote:
> Since commit b9213899d2b0 ("arm64: dts: ls1028a: disable all enetc ports
> by default") all the network ports are disabled by default. This makes
> sense, but now we have to enable them explicitly in the boards. Do so
> for the sl28 module.
>
> Since we are at it. Make sure the second port is only enabled for the
> variant 4 of the module. Variant 3 has only one network port.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports
@ 2020-02-24 11:58 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-02-24 11:58 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Mark Rutland,
Rob Herring, Li Yang
On Mon, Feb 24, 2020 at 12:50:52PM +0100, Michael Walle wrote:
> Since commit b9213899d2b0 ("arm64: dts: ls1028a: disable all enetc ports
> by default") all the network ports are disabled by default. This makes
> sense, but now we have to enable them explicitly in the boards. Do so
> for the sl28 module.
>
> Since we are at it. Make sure the second port is only enabled for the
> variant 4 of the module. Variant 3 has only one network port.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-24 11:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-24 11:50 [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports Michael Walle
2020-02-24 11:50 ` Michael Walle
2020-02-24 11:58 ` Shawn Guo
2020-02-24 11:58 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.