From: Christoph Hellwig <hch@lst.de>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
openrisc@lists.librecores.org, iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
Date: Mon, 24 Feb 2020 22:56:57 +0100 [thread overview]
Message-ID: <20200224215657.GA12618@lst.de> (raw)
In-Reply-To: <20200224215327.GB11565@iweiny-DESK2.sc.intel.com>
On Mon, Feb 24, 2020 at 01:53:28PM -0800, Ira Weiny wrote:
> > + else if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED))
> > + arch_dma_clear_uncached(cpu_addr, size);
>
> Isn't using arch_dma_clear_uncached() before patch 5 going to break
> bisectability?
Only if ARCH_HAS_DMA_CLEAR_UNCACHED is selected by anything, which
only happens in patch 5.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Jonas Bonn <jonas@southpole.se>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
iommu@lists.linux-foundation.org, openrisc@lists.librecores.org,
linux-arch@vger.kernel.org, Stafford Horne <shorne@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
Date: Mon, 24 Feb 2020 22:56:57 +0100 [thread overview]
Message-ID: <20200224215657.GA12618@lst.de> (raw)
In-Reply-To: <20200224215327.GB11565@iweiny-DESK2.sc.intel.com>
On Mon, Feb 24, 2020 at 01:53:28PM -0800, Ira Weiny wrote:
> > + else if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED))
> > + arch_dma_clear_uncached(cpu_addr, size);
>
> Isn't using arch_dma_clear_uncached() before patch 5 going to break
> bisectability?
Only if ARCH_HAS_DMA_CLEAR_UNCACHED is selected by anything, which
only happens in patch 5.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
Date: Mon, 24 Feb 2020 22:56:57 +0100 [thread overview]
Message-ID: <20200224215657.GA12618@lst.de> (raw)
In-Reply-To: <20200224215327.GB11565@iweiny-DESK2.sc.intel.com>
On Mon, Feb 24, 2020 at 01:53:28PM -0800, Ira Weiny wrote:
> > + else if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED))
> > + arch_dma_clear_uncached(cpu_addr, size);
>
> Isn't using arch_dma_clear_uncached() before patch 5 going to break
> bisectability?
Only if ARCH_HAS_DMA_CLEAR_UNCACHED is selected by anything, which
only happens in patch 5.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Jonas Bonn <jonas@southpole.se>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
iommu@lists.linux-foundation.org, openrisc@lists.librecores.org,
linux-arch@vger.kernel.org, Stafford Horne <shorne@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook
Date: Mon, 24 Feb 2020 22:56:57 +0100 [thread overview]
Message-ID: <20200224215657.GA12618@lst.de> (raw)
In-Reply-To: <20200224215327.GB11565@iweiny-DESK2.sc.intel.com>
On Mon, Feb 24, 2020 at 01:53:28PM -0800, Ira Weiny wrote:
> > + else if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED))
> > + arch_dma_clear_uncached(cpu_addr, size);
>
> Isn't using arch_dma_clear_uncached() before patch 5 going to break
> bisectability?
Only if ARCH_HAS_DMA_CLEAR_UNCACHED is selected by anything, which
only happens in patch 5.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-24 21:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 19:44 provide in-place uncached remapping for dma-direct v2 Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [OpenRISC] " Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [PATCH 1/5] dma-direct: remove the cached_kernel_address hook Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [OpenRISC] " Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [PATCH 2/5] dma-direct: consolidate the error handling in dma_direct_alloc_pages Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [OpenRISC] " Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [PATCH 3/5] dma-direct: make uncached_kernel_address more general Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [OpenRISC] " Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [PATCH 4/5] dma-direct: provide a arch_dma_clear_uncached hook Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [OpenRISC] " Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 21:53 ` Ira Weiny
2020-02-24 21:53 ` Ira Weiny
2020-02-24 21:53 ` [OpenRISC] " Ira Weiny
2020-02-24 21:53 ` Ira Weiny
2020-02-24 21:56 ` Christoph Hellwig [this message]
2020-02-24 21:56 ` Christoph Hellwig
2020-02-24 21:56 ` [OpenRISC] " Christoph Hellwig
2020-02-24 21:56 ` Christoph Hellwig
2020-02-24 19:44 ` [PATCH 5/5] openrisc: use the generic in-place uncached DMA allocator Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-24 19:44 ` [OpenRISC] " Christoph Hellwig
2020-02-24 19:44 ` Christoph Hellwig
2020-02-25 10:09 ` Stafford Horne
2020-02-25 10:09 ` Stafford Horne
2020-02-25 10:09 ` [OpenRISC] " Stafford Horne
2020-02-25 10:09 ` Stafford Horne
2020-03-02 16:05 ` provide in-place uncached remapping for dma-direct v2 Robin Murphy
2020-03-02 16:05 ` Robin Murphy
2020-03-02 16:05 ` [OpenRISC] " Robin Murphy
2020-03-02 16:05 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224215657.GA12618@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=ira.weiny@intel.com \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=openrisc@lists.librecores.org \
--cc=robin.murphy@arm.com \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.