From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: avoid unneeded barrier in do_checkpoint()
Date: Mon, 24 Feb 2020 14:00:31 -0800 [thread overview]
Message-ID: <20200224220031.GC77839@google.com> (raw)
In-Reply-To: <576f8389-ba27-b461-5466-cc62e84b5c92@huawei.com>
On 02/19, Chao Yu wrote:
> On 2020/2/19 10:51, Jaegeuk Kim wrote:
> > On 02/18, Chao Yu wrote:
> >> We don't need to wait all dirty page submitting IO twice,
> >> remove unneeded wait step.
> >
> > What happens if checkpoint and other meta writs are reordered?
>
> checkpoint can be done as following:
>
> 1. All meta except last cp-park of checkpoint area.
> 2. last cp-park of checkpoint area
>
> So we only need to keep barrier in between step 1 and 2, we don't need
> to care about the write order of meta in step 1, right?
Ah, let me integrate this patch into Sahitya's patch.
f2fs: fix the panic in do_checkpoint()
>
> Thanks,
>
> >
> >>
> >> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> >> ---
> >> fs/f2fs/checkpoint.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> >> index 751815cb4c2b..9c88fb3d255a 100644
> >> --- a/fs/f2fs/checkpoint.c
> >> +++ b/fs/f2fs/checkpoint.c
> >> @@ -1384,8 +1384,6 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> >>
> >> /* Flush all the NAT/SIT pages */
> >> f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO);
> >> - /* Wait for all dirty meta pages to be submitted for IO */
> >> - f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META);
> >>
> >> /*
> >> * modify checkpoint
> >> --
> >> 2.18.0.rc1
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH 3/3] f2fs: avoid unneeded barrier in do_checkpoint()
Date: Mon, 24 Feb 2020 14:00:31 -0800 [thread overview]
Message-ID: <20200224220031.GC77839@google.com> (raw)
In-Reply-To: <576f8389-ba27-b461-5466-cc62e84b5c92@huawei.com>
On 02/19, Chao Yu wrote:
> On 2020/2/19 10:51, Jaegeuk Kim wrote:
> > On 02/18, Chao Yu wrote:
> >> We don't need to wait all dirty page submitting IO twice,
> >> remove unneeded wait step.
> >
> > What happens if checkpoint and other meta writs are reordered?
>
> checkpoint can be done as following:
>
> 1. All meta except last cp-park of checkpoint area.
> 2. last cp-park of checkpoint area
>
> So we only need to keep barrier in between step 1 and 2, we don't need
> to care about the write order of meta in step 1, right?
Ah, let me integrate this patch into Sahitya's patch.
f2fs: fix the panic in do_checkpoint()
>
> Thanks,
>
> >
> >>
> >> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> >> ---
> >> fs/f2fs/checkpoint.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> >> index 751815cb4c2b..9c88fb3d255a 100644
> >> --- a/fs/f2fs/checkpoint.c
> >> +++ b/fs/f2fs/checkpoint.c
> >> @@ -1384,8 +1384,6 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> >>
> >> /* Flush all the NAT/SIT pages */
> >> f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO);
> >> - /* Wait for all dirty meta pages to be submitted for IO */
> >> - f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META);
> >>
> >> /*
> >> * modify checkpoint
> >> --
> >> 2.18.0.rc1
> > .
> >
next prev parent reply other threads:[~2020-02-24 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 10:21 [f2fs-dev] [PATCH 1/3] f2fs: avoid __GFP_NOFAIL in f2fs_bio_alloc Chao Yu
2020-02-18 10:21 ` Chao Yu
2020-02-18 10:21 ` [f2fs-dev] [PATCH 2/3] f2fs: fix to avoid triggering IO in write path Chao Yu
2020-02-18 10:21 ` Chao Yu
2020-02-18 10:21 ` [f2fs-dev] [PATCH 3/3] f2fs: avoid unneeded barrier in do_checkpoint() Chao Yu
2020-02-18 10:21 ` Chao Yu
2020-02-19 2:51 ` [f2fs-dev] " Jaegeuk Kim
2020-02-19 2:51 ` Jaegeuk Kim
2020-02-19 3:18 ` [f2fs-dev] " Chao Yu
2020-02-19 3:18 ` Chao Yu
2020-02-24 22:00 ` Jaegeuk Kim [this message]
2020-02-24 22:00 ` Jaegeuk Kim
2020-02-25 6:10 ` [f2fs-dev] " Chao Yu
2020-02-25 6:10 ` Chao Yu
2020-02-19 2:49 ` [f2fs-dev] [PATCH 1/3] f2fs: avoid __GFP_NOFAIL in f2fs_bio_alloc Jaegeuk Kim
2020-02-19 2:49 ` Jaegeuk Kim
2020-02-19 3:12 ` [f2fs-dev] " Chao Yu
2020-02-19 3:12 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224220031.GC77839@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.