Re: [PATCH v24 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob

[Igor Mammedov <imammedo@redhat.com>]

On Tue, 25 Feb 2020 09:48:04 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> On Mon, 17 Feb 2020 21:12:42 +0800
> Dongjiu Geng <gengdongjiu@huawei.com> wrote:
> 
> > This patch builds error_block_address and read_ack_register fields
> > in hardware errors table , the error_block_address points to Generic
> > Error Status Block(GESB) via bios_linker. The max size for one GESB
> > is 1kb in bytes, For more detailed information, please refer to  
> 
> s/1kb in bytes/1Kb/
> 
> > document: docs/specs/acpi_hest_ghes.rst
> > 
> > Now we only support one Error source, if necessary, we can extend to
> > support more.
> > 
> > Suggested-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
> > Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---  
>

On the second glance,


[...]
> > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> > index bd5f771..6819fcf 100644
> > --- a/hw/arm/virt-acpi-build.c
> > +++ b/hw/arm/virt-acpi-build.c
> > @@ -48,6 +48,7 @@
> >  #include "sysemu/reset.h"
> >  #include "kvm_arm.h"
> >  #include "migration/vmstate.h"
> > +#include "hw/acpi/ghes.h"
> >  
> >  #define ARM_SPI_BASE 32
> >  
> > @@ -830,6 +831,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
> >      acpi_add_table(table_offsets, tables_blob);
> >      build_spcr(tables_blob, tables->linker, vms);
> >  
> > +    if (vms->ras) {

> > +        acpi_add_table(table_offsets, tables_blob);
that doesn't look right, it's for tables that  should be referenced
from XSDT

> > +        build_ghes_error_table(tables->hardware_errors, tables->linker);

but this table isn't pointed by XSDT directly.

I suggest to move acpi_add_table() to the patch that adds acpi_build_hest()

> > +    }
> > +
> >      if (ms->numa_state->num_nodes > 0) {
> >          acpi_add_table(table_offsets, tables_blob);
> >          build_srat(tables_blob, tables->linker, vms);
[...]