Re: [PATCH v7 11/11] arm64: mm: Display guarded pages in ptdump

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Kees Cook <keescook@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Paul Elliott" <paul.elliott@arm.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
	"Amit Kachhap" <amit.kachhap@arm.com>,
	"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Eugene Syromiatnikov" <esyr@redhat.com>,
	"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
	"H . J . Lu " <hjl.tools@gmail.com>,
	"Andrew Jones" <drjones@redhat.com>,
	"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Kristina Martšenko" <kristina.martsenko@arm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Florian Weimer" <fweimer@redhat.com>
Subject: Re: [PATCH v7 11/11] arm64: mm: Display guarded pages in ptdump
Date: Wed, 26 Feb 2020 13:38:53 -0800	[thread overview]
Message-ID: <202002261338.9890367C@keescook> (raw)
In-Reply-To: <20200226155714.43937-12-broonie@kernel.org>

On Wed, Feb 26, 2020 at 03:57:14PM +0000, Mark Brown wrote:
> v8.5-BTI introduces the GP field in stage 1 translation tables which
> indicates that blocks and pages with it set are guarded pages for which
> branch target identification checks should be performed. Decode this
> when dumping the page tables to aid debugging.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  arch/arm64/mm/dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 860c00ec8bd3..78163b7a7dde 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -145,6 +145,11 @@ static const struct prot_bits pte_bits[] = {
>  		.val	= PTE_UXN,
>  		.set	= "UXN",
>  		.clear	= "   ",
> +	}, {
> +		.mask	= PTE_GP,
> +		.val	= PTE_GP,
> +		.set	= "GP",
> +		.clear	= "  ",
>  	}, {
>  		.mask	= PTE_ATTRINDX_MASK,
>  		.val	= PTE_ATTRINDX(MT_DEVICE_nGnRnE),
> -- 
> 2.20.1
> 

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)

From: Kees Cook <keescook@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Paul Elliott" <paul.elliott@arm.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
	"Amit Kachhap" <amit.kachhap@arm.com>,
	"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Eugene Syromiatnikov" <esyr@redhat.com>,
	"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
	"H . J . Lu " <hjl.tools@gmail.com>,
	"Andrew Jones" <drjones@redhat.com>,
	"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Kristina Martšenko" <kristina.martsenko@arm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Florian Weimer" <fweimer@redhat.com>,
	"Sudakshina Das" <sudi.das@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 11/11] arm64: mm: Display guarded pages in ptdump
Date: Wed, 26 Feb 2020 13:38:53 -0800	[thread overview]
Message-ID: <202002261338.9890367C@keescook> (raw)
Message-ID: <20200226213853.tai05mkZaNB2TMyJFbxfragGREb5FGANsURbJ8vf7yg@z> (raw)
In-Reply-To: <20200226155714.43937-12-broonie@kernel.org>

On Wed, Feb 26, 2020 at 03:57:14PM +0000, Mark Brown wrote:
> v8.5-BTI introduces the GP field in stage 1 translation tables which
> indicates that blocks and pages with it set are guarded pages for which
> branch target identification checks should be performed. Decode this
> when dumping the page tables to aid debugging.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  arch/arm64/mm/dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 860c00ec8bd3..78163b7a7dde 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -145,6 +145,11 @@ static const struct prot_bits pte_bits[] = {
>  		.val	= PTE_UXN,
>  		.set	= "UXN",
>  		.clear	= "   ",
> +	}, {
> +		.mask	= PTE_GP,
> +		.val	= PTE_GP,
> +		.set	= "GP",
> +		.clear	= "  ",
>  	}, {
>  		.mask	= PTE_ATTRINDX_MASK,
>  		.val	= PTE_ATTRINDX(MT_DEVICE_nGnRnE),
> -- 
> 2.20.1
> 

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)

From: Kees Cook <keescook@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Paul Elliott" <paul.elliott@arm.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Andrew Jones" <drjones@redhat.com>,
	"Amit Kachhap" <amit.kachhap@arm.com>,
	"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
	"Will Deacon" <will@kernel.org>,
	linux-arch@vger.kernel.org, "Marc Zyngier" <maz@kernel.org>,
	"Eugene Syromiatnikov" <esyr@redhat.com>,
	"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
	"H . J . Lu " <hjl.tools@gmail.com>,
	"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
	"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Kristina Martšenko" <kristina.martsenko@arm.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"Florian Weimer" <fweimer@redhat.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	"Sudakshina Das" <sudi.das@arm.com>
Subject: Re: [PATCH v7 11/11] arm64: mm: Display guarded pages in ptdump
Date: Wed, 26 Feb 2020 13:38:53 -0800	[thread overview]
Message-ID: <202002261338.9890367C@keescook> (raw)
In-Reply-To: <20200226155714.43937-12-broonie@kernel.org>

On Wed, Feb 26, 2020 at 03:57:14PM +0000, Mark Brown wrote:
> v8.5-BTI introduces the GP field in stage 1 translation tables which
> indicates that blocks and pages with it set are guarded pages for which
> branch target identification checks should be performed. Decode this
> when dumping the page tables to aid debugging.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  arch/arm64/mm/dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 860c00ec8bd3..78163b7a7dde 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -145,6 +145,11 @@ static const struct prot_bits pte_bits[] = {
>  		.val	= PTE_UXN,
>  		.set	= "UXN",
>  		.clear	= "   ",
> +	}, {
> +		.mask	= PTE_GP,
> +		.val	= PTE_GP,
> +		.set	= "GP",
> +		.clear	= "  ",
>  	}, {
>  		.mask	= PTE_ATTRINDX_MASK,
>  		.val	= PTE_ATTRINDX(MT_DEVICE_nGnRnE),
> -- 
> 2.20.1
> 

-- 
Kees Cook

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2020-02-26 21:38 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 15:57 [PATCH v7 00/11] arm64: Branch Target Identification support Mark Brown
2020-02-26 15:57 ` Mark Brown
2020-02-26 15:57 ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 01/11] ELF: UAPI and Kconfig additions for ELF program properties Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 02/11] ELF: Add ELF program property parsing support Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 03/11] arm64: Basic Branch Target Identification support Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 04/11] elf: Allow arch to tweak initial mmap prot flags Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 05/11] arm64: elf: Enable BTI at exec based on ELF program properties Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 21:43   ` Kees Cook
2020-02-26 21:43     ` Kees Cook
2020-02-26 21:43     ` Kees Cook
2020-02-27  4:45   ` Amit Kachhap
2020-02-27  4:45     ` Amit Kachhap
2020-02-27  4:45     ` Amit Kachhap
2020-02-26 15:57 ` [PATCH v7 06/11] arm64: BTI: Decode BYTPE bits when printing PSTATE Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 21:42   ` Kees Cook
2020-02-26 21:42     ` Kees Cook
2020-02-26 21:42     ` Kees Cook
2020-02-26 15:57 ` [PATCH v7 07/11] arm64: unify native/compat instruction skipping Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 21:41   ` Kees Cook
2020-02-26 21:41     ` Kees Cook
2020-02-26 21:41     ` Kees Cook
2020-02-26 15:57 ` [PATCH v7 08/11] arm64: traps: Shuffle code to eliminate forward declarations Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 21:39   ` Kees Cook
2020-02-26 21:39     ` Kees Cook
2020-02-26 21:39     ` Kees Cook
2020-02-26 15:57 ` [PATCH v7 09/11] arm64: BTI: Reset BTYPE when skipping emulated instructions Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 10/11] KVM: " Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57 ` [PATCH v7 11/11] arm64: mm: Display guarded pages in ptdump Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 15:57   ` Mark Brown
2020-02-26 21:38   ` Kees Cook [this message]
2020-02-26 21:38     ` Kees Cook
2020-02-26 21:38     ` Kees Cook
2020-02-26 21:44 ` [PATCH v7 00/11] arm64: Branch Target Identification support Kees Cook
2020-02-26 21:44   ` Kees Cook
2020-02-26 21:44   ` Kees Cook
2020-02-27 13:13   ` Mark Brown
2020-02-27 13:13     ` Mark Brown
2020-02-27 13:13     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202002261338.9890367C@keescook \
    --to=keescook@chromium.org \
    --cc=amit.kachhap@arm.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=drjones@redhat.com \
    --cc=esyr@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=jannh@google.com \
    --cc=kristina.martsenko@arm.com \
    --cc=maz@kernel.org \
    --cc=paul.elliott@arm.com \
    --cc=peterz@infradead.org \
    --cc=richard.henderson@linaro.org \
    --cc=szabolcs.nagy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.