From: mark gross <mgross@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1
Date: Wed, 26 Feb 2020 09:11:03 -0800 [thread overview]
Message-ID: <20200226171103.GA114268@mtg-dev.jf.intel.com> (raw)
In-Reply-To: <20200226110737.GB17448@zn.tnic>
On Wed, Feb 26, 2020 at 12:07:37PM +0100, speck for Borislav Petkov wrote:
> On Thu, Feb 06, 2020 at 02:11:02PM -0800, speck for mark gross wrote:
> > From: mark gross <mgross@linux.intel.com>
> > Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in the
> > vulnerability white list structure.
> >
> > From: mark gross <mgross@linux.intel.com>
> > Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in the
>
> That second subject is incomplete. Do just one pls.
Ok FWIW the instructions for using the speckify-gitmail said something about
copying the subject and from lines into the body.
> Also, you need a subject prefix:
>
> x86/CPU: Add ...
ok
>
> git log arch/x86/
>
> is your friend if you're wondering what to call it.
Thanks!
> > Intel has produced processors with the same CPUID family+model. Code
> > may need to check the stepping when programming model specific behavior.
> >
> > Add an API to allow easy specification of stepping or range of steppings
> > with a 16 bit bitmask.
> >
> > Update cpu_vuln_whitelist using this new API.
> >
> > I implemented this in the way I did to avoid modifying x86_cpu_id as
> > that structure is an exported ABI and any change would impact user mode
> > code using the structure.
>
> Exported ABI? Which usermode code uses this? The module loading tools?
Yeah, Andi pointed it out to me on an internal review. I don't know what tool
is using it.
>
> Even if, we do add new struct members at the end of exported structs
> just fine. So what is the problem here?
FWIW doing it this way made a cleaner patch without touching a dozen other
files using that structure. I'd rather stay with the way it is but, if you
feel strongly I can do a version of what I had before only adding the new
members to the end. Please let me know.
> > Signed-off-by: mark gross <mgross@linux.intel.com>
> > Reviewed-by: tony luck <tony.luck@intel.com>
>
> Please write names capitalized.
Ok.
Thanks!
--mark
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> --
next prev parent reply other threads:[~2020-02-26 17:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 21:45 [MODERATED] [PATCH v2 0/2] v2: more sampling fun 0 mark gross
2020-01-16 22:16 ` [MODERATED] [PATCH v2 2/2] v2: more sampling fun 2 mark gross
2020-02-06 22:11 ` [MODERATED] [PATCH v2 1/2] v2: more sampling fun 1 mark gross
2020-02-25 16:55 ` [MODERATED] Re: [PATCH v2 0/2] v2: more sampling fun 0 Josh Poimboeuf
2020-02-25 17:43 ` mark gross
2020-02-25 20:47 ` Thomas Gleixner
2020-02-25 21:51 ` [MODERATED] " mark gross
[not found] ` <5e5595e6.1c69fb81.69e80.2880SMTPIN_ADDED_BROKEN@mx.google.com>
2020-02-26 7:27 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Greg KH
2020-02-26 18:02 ` mark gross
2020-02-26 11:07 ` [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Borislav Petkov
2020-02-26 17:11 ` mark gross [this message]
2020-02-26 17:59 ` Borislav Petkov
2020-02-26 18:16 ` Thomas Gleixner
2020-02-26 22:13 ` [MODERATED] " mark gross
2020-02-26 23:53 ` Thomas Gleixner
2020-02-27 16:43 ` [MODERATED] " mark gross
2020-02-26 22:11 ` mark gross
2020-02-26 22:43 ` Borislav Petkov
2020-02-26 23:34 ` mark gross
2020-02-26 18:55 ` Thomas Gleixner
2020-02-26 22:23 ` [MODERATED] " mark gross
2020-02-26 21:13 ` Andi Kleen
2020-02-26 22:01 ` Thomas Gleixner
2020-02-27 7:08 ` [MODERATED] " Greg KH
2020-02-26 11:46 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Borislav Petkov
2020-02-26 17:35 ` mark gross
2020-02-26 18:13 ` Borislav Petkov
2020-02-26 22:37 ` mark gross
2020-02-26 22:50 ` Borislav Petkov
2020-02-26 23:42 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226171103.GA114268@mtg-dev.jf.intel.com \
--to=mgross@linux.intel.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.