All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ondrej Jirman <megous@megous.com>
Cc: linux-sunxi@googlegroups.com,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <mripard@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led
Date: Wed, 26 Feb 2020 16:30:32 -0600	[thread overview]
Message-ID: <20200226223032.GA13404@bogus> (raw)
In-Reply-To: <20200223131435.681620-2-megous@megous.com>

On Sun, Feb 23, 2020 at 02:14:32PM +0100, Ondrej Jirman wrote:
> The AXP813 PMIC can control one LED. Add binding to represent the LED.
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  .../devicetree/bindings/leds/leds-axp20x.yaml | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-axp20x.yaml b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> new file mode 100644
> index 0000000000000..79282d55764bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-axp20x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for AXP813 PMIC from X-Powers.
> +
> +maintainers:
> +  - Ondrej Jirman <megous@megous.com>
> +
> +description: |
> +  This module is part of the AXP20x MFD device. For more details
> +  see Documentation/devicetree/bindings/mfd/axp20x.txt.

Really, we should convert this first as this should either just be 
referenced from the MFD schema or just directly put into it.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Ondrej Jirman <megous@megous.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <mripard@kernel.org>,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
	linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led
Date: Wed, 26 Feb 2020 16:30:32 -0600	[thread overview]
Message-ID: <20200226223032.GA13404@bogus> (raw)
In-Reply-To: <20200223131435.681620-2-megous@megous.com>

On Sun, Feb 23, 2020 at 02:14:32PM +0100, Ondrej Jirman wrote:
> The AXP813 PMIC can control one LED. Add binding to represent the LED.
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  .../devicetree/bindings/leds/leds-axp20x.yaml | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-axp20x.yaml b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> new file mode 100644
> index 0000000000000..79282d55764bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-axp20x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for AXP813 PMIC from X-Powers.
> +
> +maintainers:
> +  - Ondrej Jirman <megous@megous.com>
> +
> +description: |
> +  This module is part of the AXP20x MFD device. For more details
> +  see Documentation/devicetree/bindings/mfd/axp20x.txt.

Really, we should convert this first as this should either just be 
referenced from the MFD schema or just directly put into it.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-02-26 22:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-23 13:14 [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Ondrej Jirman
2020-02-23 13:14 ` Ondrej Jirman
2020-02-23 13:14 ` [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led Ondrej Jirman
2020-02-23 13:14   ` Ondrej Jirman
2020-02-25 12:55   ` Dan Murphy
2020-02-25 12:55     ` Dan Murphy
2020-02-26 22:30   ` Rob Herring [this message]
2020-02-26 22:30     ` Rob Herring
2020-02-23 13:14 ` [PATCH 2/4] leds: axp20x: Support charger LED on AXP20x like PMICs Ondrej Jirman
2020-02-23 13:14   ` Ondrej Jirman
2020-02-25 12:53   ` Dan Murphy
2020-02-25 12:53     ` Dan Murphy
2020-02-26 14:08   ` Pavel Machek
2020-02-26 14:08     ` Pavel Machek
2020-02-23 13:14 ` [PATCH 3/4] ARM: dts: axp813: Add charger LED Ondrej Jirman
2020-02-23 13:14   ` Ondrej Jirman
2020-02-25 12:56   ` Dan Murphy
2020-02-25 12:56     ` Dan Murphy
2020-02-23 13:14 ` [PATCH 4/4] ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED Ondrej Jirman
2020-02-23 13:14   ` Ondrej Jirman
2020-02-23 13:27 ` [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Ondřej Jirman
2020-02-23 13:27   ` Ondřej Jirman
2020-02-23 13:35   ` Ondřej Jirman
2020-02-23 13:35     ` Ondřej Jirman
2020-02-24  6:31     ` [linux-sunxi] " Stefan Mavrodiev
2020-02-24  6:31       ` Stefan Mavrodiev
2020-02-24 16:28       ` Ondřej Jirman
2020-02-24 16:28         ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226223032.GA13404@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.