* [PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning [not found] <CGME20200227070649eucas1p15dcf4847b369fc20bd2a96f697b1173b@eucas1p1.samsung.com> @ 2020-02-27 7:06 ` Marek Szyprowski 0 siblings, 0 replies; 4+ messages in thread From: Marek Szyprowski @ 2020-02-27 7:06 UTC (permalink / raw) To: dri-devel, linux-samsung-soc Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Inki Dae, Andrzej Hajda, Krzysztof Kozlowski Properly propagate error value from devm_regulator_bulk_get() and don't confuse user with meaningless warning about failure in getting regulators in case of deferred probe. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v2: rephrased commit message --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 33628d85edad..3f6fcd453d33 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1773,8 +1773,9 @@ static int exynos_dsi_probe(struct platform_device *pdev) ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dsi->supplies), dsi->supplies); if (ret) { - dev_info(dev, "failed to get regulators: %d\n", ret); - return -EPROBE_DEFER; + if (ret != -EPROBE_DEFER) + dev_info(dev, "failed to get regulators: %d\n", ret); + return ret; } dsi->clks = devm_kcalloc(dev, -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning @ 2020-02-27 7:06 ` Marek Szyprowski 0 siblings, 0 replies; 4+ messages in thread From: Marek Szyprowski @ 2020-02-27 7:06 UTC (permalink / raw) To: dri-devel, linux-samsung-soc Cc: Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Krzysztof Kozlowski, Andrzej Hajda, Marek Szyprowski Properly propagate error value from devm_regulator_bulk_get() and don't confuse user with meaningless warning about failure in getting regulators in case of deferred probe. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v2: rephrased commit message --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 33628d85edad..3f6fcd453d33 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1773,8 +1773,9 @@ static int exynos_dsi_probe(struct platform_device *pdev) ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dsi->supplies), dsi->supplies); if (ret) { - dev_info(dev, "failed to get regulators: %d\n", ret); - return -EPROBE_DEFER; + if (ret != -EPROBE_DEFER) + dev_info(dev, "failed to get regulators: %d\n", ret); + return ret; } dsi->clks = devm_kcalloc(dev, -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning 2020-02-27 7:06 ` Marek Szyprowski @ 2020-02-27 8:04 ` Krzysztof Kozlowski -1 siblings, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2020-02-27 8:04 UTC (permalink / raw) To: Marek Szyprowski Cc: dri-devel, linux-samsung-soc, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Inki Dae, Andrzej Hajda On Thu, Feb 27, 2020 at 08:06:37AM +0100, Marek Szyprowski wrote: > Properly propagate error value from devm_regulator_bulk_get() and don't > confuse user with meaningless warning about failure in getting regulators > in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v2: rephrased commit message > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning @ 2020-02-27 8:04 ` Krzysztof Kozlowski 0 siblings, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2020-02-27 8:04 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Bartlomiej Zolnierkiewicz, Seung-Woo Kim, dri-devel, Andrzej Hajda On Thu, Feb 27, 2020 at 08:06:37AM +0100, Marek Szyprowski wrote: > Properly propagate error value from devm_regulator_bulk_get() and don't > confuse user with meaningless warning about failure in getting regulators > in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v2: rephrased commit message > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-27 8:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200227070649eucas1p15dcf4847b369fc20bd2a96f697b1173b@eucas1p1.samsung.com>
2020-02-27 7:06 ` [PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning Marek Szyprowski
2020-02-27 7:06 ` Marek Szyprowski
2020-02-27 8:04 ` Krzysztof Kozlowski
2020-02-27 8:04 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.