[virtio-dev] [PATCH] virtio-gpu: some edid clarifications

[virtio-dev] [PATCH] virtio-gpu: some edid clarifications

[Gerd Hoffmann]

Add some notes about fetching the EDID information.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 virtio-gpu.tex | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/virtio-gpu.tex b/virtio-gpu.tex
index af4ca610d235..15dbf9f2ec82 100644
--- a/virtio-gpu.tex
+++ b/virtio-gpu.tex
@@ -70,16 +70,21 @@ \subsubsection{Events}
 \begin{description}
 \item[VIRTIO_GPU_EVENT_DISPLAY] Display configuration has changed.
   The driver SHOULD use the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command to
-  fetch the information from the device.
+  fetch the information from the device.  In case EDID support is
+  negotiated (VIRTIO_GPU_F_EDID feature flag) the device SHOULD also
+  fetch the updated EDID blobs using the VIRTIO_GPU_CMD_GET_EDID
+  command.
 \end{description}
 
 \devicenormative{\subsection}{Device Initialization}{Device Types / GPU Device / Device Initialization}
 
 The driver SHOULD query the display information from the device using
 the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command and use that information
-for the initial scanout setup.  In case no information is available or
-all displays are disabled the driver MAY choose to use a fallback,
-such as 1024x768 at display 0.
+for the initial scanout setup.  In case EDID support is negotiated
+(VIRTIO_GPU_F_EDID feature flag) the device SHOULD also fetch the EDID
+information using the VIRTIO_GPU_CMD_GET_EDID command.  If no
+information is available or all displays are disabled the driver MAY
+choose to use a fallback, such as 1024x768 at display 0.
 
 \subsection{Device Operation}\label{sec:Device Types / GPU Device / Device Operation}
 
-- 
2.18.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] [PATCH] virtio-gpu: some edid clarifications

[Michael S. Tsirkin]

On Thu, Nov 28, 2019 at 12:42:43PM +0100, Gerd Hoffmann wrote:
> Add some notes about fetching the EDID information.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

As a minor nit, it is preferable to send spec patches on virtio-comment.

virtio-dev is for code patches (implementation development).


> ---
>  virtio-gpu.tex | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/virtio-gpu.tex b/virtio-gpu.tex
> index af4ca610d235..15dbf9f2ec82 100644
> --- a/virtio-gpu.tex
> +++ b/virtio-gpu.tex
> @@ -70,16 +70,21 @@ \subsubsection{Events}
>  \begin{description}
>  \item[VIRTIO_GPU_EVENT_DISPLAY] Display configuration has changed.
>    The driver SHOULD use the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command to
> -  fetch the information from the device.
> +  fetch the information from the device.  In case EDID support is
> +  negotiated (VIRTIO_GPU_F_EDID feature flag) the device SHOULD also
> +  fetch the updated EDID blobs using the VIRTIO_GPU_CMD_GET_EDID
> +  command.
>  \end{description}
>  
>  \devicenormative{\subsection}{Device Initialization}{Device Types / GPU Device / Device Initialization}
>  
>  The driver SHOULD query the display information from the device using
>  the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command and use that information
> -for the initial scanout setup.  In case no information is available or
> -all displays are disabled the driver MAY choose to use a fallback,
> -such as 1024x768 at display 0.
> +for the initial scanout setup.  In case EDID support is negotiated
> +(VIRTIO_GPU_F_EDID feature flag) the device SHOULD also fetch the EDID
> +information using the VIRTIO_GPU_CMD_GET_EDID command.  If no
> +information is available or all displays are disabled the driver MAY
> +choose to use a fallback, such as 1024x768 at display 0.
>  
>  \subsection{Device Operation}\label{sec:Device Types / GPU Device / Device Operation}
>  
> -- 
> 2.18.1
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH] virtio-gpu: some edid clarifications

[Gerd Hoffmann]

On Thu, Nov 28, 2019 at 12:42:43PM +0100, Gerd Hoffmann wrote:
> Add some notes about fetching the EDID information.

https://github.com/oasis-tcs/virtio-spec/issues/64

cheers,
  Gerd


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] Re: [PATCH] virtio-gpu: some edid clarifications

[Michael S. Tsirkin]

On Tue, Dec 03, 2019 at 10:35:10AM +0100, Gerd Hoffmann wrote:
> On Thu, Nov 28, 2019 at 12:42:43PM +0100, Gerd Hoffmann wrote:
> > Add some notes about fetching the EDID information.
> 
> https://github.com/oasis-tcs/virtio-spec/issues/64
> 
> cheers,
>   Gerd


I pushed it now but it all needed a bunch of manual tweaking.
Gerd I'd appreciate it if you follow the process described
in README.md section "Use of github issues" in the future. Thanks!

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org