From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in
Date: Thu, 27 Feb 2020 11:55:51 +0100 [thread overview]
Message-ID: <20200227105551.GA7995@pi3> (raw)
In-Reply-To: <20200227093027.17349-1-m.szyprowski@samsung.com>
On Thu, Feb 27, 2020 at 10:30:27AM +0100, Marek Szyprowski wrote:
> Exynos OHCI and EHCI drivers are already selected as built-in, but they
> both require Samsung USB2 Generic PHY driver to operate properly. Mark
> that driver as built-in, otherwise having Exynos OHCI and EHCI drivers
> built-in makes no sense.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
How about going the other way - making EHCI a module (OHCI is =m
already)? multi_v7 requires initrd anyway for many boot configurations
so such change would not affect much.
Best regards,
Krzysztof
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 7c8a1c310bbb..04a68efb3ddb 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -1055,7 +1055,7 @@ CONFIG_PHY_QCOM_APQ8064_SATA=m
> CONFIG_PHY_RCAR_GEN2=m
> CONFIG_PHY_ROCKCHIP_DP=m
> CONFIG_PHY_ROCKCHIP_USB=y
> -CONFIG_PHY_SAMSUNG_USB2=m
> +CONFIG_PHY_SAMSUNG_USB2=y
> CONFIG_PHY_EXYNOS5250_SATA=m
> CONFIG_PHY_UNIPHIER_USB2=y
> CONFIG_PHY_UNIPHIER_USB3=y
> --
> 2.17.1
>
prev parent reply other threads:[~2020-02-27 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200227093037eucas1p21e47bb8372b87ce1a3efd9ac943b6c7d@eucas1p2.samsung.com>
2020-02-27 9:30 ` [PATCH] ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in Marek Szyprowski
2020-02-27 10:55 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227105551.GA7995@pi3 \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.