* [PATCH] ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in
[not found] <CGME20200227093037eucas1p21e47bb8372b87ce1a3efd9ac943b6c7d@eucas1p2.samsung.com>
@ 2020-02-27 9:30 ` Marek Szyprowski
2020-02-27 10:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2020-02-27 9:30 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz
Exynos OHCI and EHCI drivers are already selected as built-in, but they
both require Samsung USB2 Generic PHY driver to operate properly. Mark
that driver as built-in, otherwise having Exynos OHCI and EHCI drivers
built-in makes no sense.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7c8a1c310bbb..04a68efb3ddb 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -1055,7 +1055,7 @@ CONFIG_PHY_QCOM_APQ8064_SATA=m
CONFIG_PHY_RCAR_GEN2=m
CONFIG_PHY_ROCKCHIP_DP=m
CONFIG_PHY_ROCKCHIP_USB=y
-CONFIG_PHY_SAMSUNG_USB2=m
+CONFIG_PHY_SAMSUNG_USB2=y
CONFIG_PHY_EXYNOS5250_SATA=m
CONFIG_PHY_UNIPHIER_USB2=y
CONFIG_PHY_UNIPHIER_USB3=y
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in
2020-02-27 9:30 ` [PATCH] ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in Marek Szyprowski
@ 2020-02-27 10:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-02-27 10:55 UTC (permalink / raw)
To: Marek Szyprowski; +Cc: linux-samsung-soc, Bartlomiej Zolnierkiewicz
On Thu, Feb 27, 2020 at 10:30:27AM +0100, Marek Szyprowski wrote:
> Exynos OHCI and EHCI drivers are already selected as built-in, but they
> both require Samsung USB2 Generic PHY driver to operate properly. Mark
> that driver as built-in, otherwise having Exynos OHCI and EHCI drivers
> built-in makes no sense.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
How about going the other way - making EHCI a module (OHCI is =m
already)? multi_v7 requires initrd anyway for many boot configurations
so such change would not affect much.
Best regards,
Krzysztof
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 7c8a1c310bbb..04a68efb3ddb 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -1055,7 +1055,7 @@ CONFIG_PHY_QCOM_APQ8064_SATA=m
> CONFIG_PHY_RCAR_GEN2=m
> CONFIG_PHY_ROCKCHIP_DP=m
> CONFIG_PHY_ROCKCHIP_USB=y
> -CONFIG_PHY_SAMSUNG_USB2=m
> +CONFIG_PHY_SAMSUNG_USB2=y
> CONFIG_PHY_EXYNOS5250_SATA=m
> CONFIG_PHY_UNIPHIER_USB2=y
> CONFIG_PHY_UNIPHIER_USB3=y
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200227093037eucas1p21e47bb8372b87ce1a3efd9ac943b6c7d@eucas1p2.samsung.com>
2020-02-27 9:30 ` [PATCH] ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in Marek Szyprowski
2020-02-27 10:55 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.