From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
netdev <netdev@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver
Date: Thu, 27 Feb 2020 17:40:40 +0000 [thread overview]
Message-ID: <20200227174040.GP25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200227173636.GE5245@lunn.ch>
On Thu, Feb 27, 2020 at 06:36:36PM +0100, Andrew Lunn wrote:
> > > > + allOf:
> > > > + - $ref: /schemas/types.yaml#/definitions/uint16-array
> > > > + - minItems: 1
> > > > + maxItems: 4
> > > > +
> > > > +examples:
> > > > + - |
> > > > + ethernet-phy@0 {
> > > > + reg = <0>;
> > >
> > > This needs to be under an 'mdio' node with #address-cells and
> > > #size-cells set correctly.
> >
> > I wish these things were documented somewhere... I'm pretty sure this
> > passed validation when I wrote it.
>
> Documentation/devicetree/bindings/net/mdio.yaml
I'm not sure that makes it any more obvious. Maybe it's obvious to
those who understand yaml, but for the rest of us, it isn't.
> Rob, is there a way to express the hierarchy between yaml files and
> properties? Can we say that a phy, as defined by ethernet-phy.yaml
> should always be inside an MDIO bus as defined in mdio.yaml?
and yes, it isn't even referenced from ethernet-phy.yaml, so how one
would know to even look there.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
netdev <netdev@vger.kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver
Date: Thu, 27 Feb 2020 17:40:40 +0000 [thread overview]
Message-ID: <20200227174040.GP25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200227173636.GE5245@lunn.ch>
On Thu, Feb 27, 2020 at 06:36:36PM +0100, Andrew Lunn wrote:
> > > > + allOf:
> > > > + - $ref: /schemas/types.yaml#/definitions/uint16-array
> > > > + - minItems: 1
> > > > + maxItems: 4
> > > > +
> > > > +examples:
> > > > + - |
> > > > + ethernet-phy@0 {
> > > > + reg = <0>;
> > >
> > > This needs to be under an 'mdio' node with #address-cells and
> > > #size-cells set correctly.
> >
> > I wish these things were documented somewhere... I'm pretty sure this
> > passed validation when I wrote it.
>
> Documentation/devicetree/bindings/net/mdio.yaml
I'm not sure that makes it any more obvious. Maybe it's obvious to
those who understand yaml, but for the rest of us, it isn't.
> Rob, is there a way to express the hierarchy between yaml files and
> properties? Can we say that a phy, as defined by ethernet-phy.yaml
> should always be inside an MDIO bus as defined in mdio.yaml?
and yes, it isn't even referenced from ethernet-phy.yaml, so how one
would know to even look there.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-02-27 17:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 9:51 [PATCH net-next 0/3] Add support for configuring Marvell 10G PHY LEDs Russell King - ARM Linux admin
2020-02-27 9:51 ` Russell King - ARM Linux admin
2020-02-27 9:52 ` [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver Russell King
2020-02-27 9:52 ` Russell King
2020-02-27 17:08 ` Rob Herring
2020-02-27 17:08 ` Rob Herring
2020-02-27 17:14 ` Russell King - ARM Linux admin
2020-02-27 17:14 ` Russell King - ARM Linux admin
2020-02-27 17:13 ` Rob Herring
2020-02-27 17:13 ` Rob Herring
2020-02-27 17:26 ` Russell King - ARM Linux admin
2020-02-27 17:26 ` Russell King - ARM Linux admin
2020-02-27 17:36 ` Andrew Lunn
2020-02-27 17:36 ` Andrew Lunn
2020-02-27 17:40 ` Russell King - ARM Linux admin [this message]
2020-02-27 17:40 ` Russell King - ARM Linux admin
2020-02-27 20:11 ` Rob Herring
2020-02-27 20:11 ` Rob Herring
2020-02-27 17:44 ` Florian Fainelli
2020-02-27 17:44 ` Florian Fainelli
2020-02-27 18:59 ` Russell King - ARM Linux admin
2020-02-27 18:59 ` Russell King - ARM Linux admin
2020-02-27 9:52 ` [PATCH net-next 2/3] net: phy: marvell10g: add support for configuring LEDs Russell King
2020-02-27 9:52 ` Russell King
2020-02-27 9:52 ` [PATCH net-next 3/3] arm64: dts: configure Macchiatobin 10G PHY LED modes Russell King
2020-02-27 9:52 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227174040.GP25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.