From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Hui Wang <hui.wang@canonical.com>,
vkoul@kernel.org, broonie@kernel.org,
srinivas.kandagatla@linaro.org, jank@cadence.com,
slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [PATCH 2/8] soundwire: intel: transition to sdw_master_device/driver support
Date: Fri, 28 Feb 2020 08:34:16 +0100 [thread overview]
Message-ID: <20200228073416.GC2898712@kroah.com> (raw)
In-Reply-To: <20200227223206.5020-3-pierre-louis.bossart@linux.intel.com>
On Thu, Feb 27, 2020 at 04:32:00PM -0600, Pierre-Louis Bossart wrote:
> +static struct sdw_master_driver intel_sdw_driver = {
> + .driver = {
> + .name = "intel-master",
> + .owner = THIS_MODULE,
Nit, setting .owner isn't needed anymore, as the core code handles this
for you, right?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org,
jank@cadence.com, srinivas.kandagatla@linaro.org,
slawomir.blauciak@intel.com,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Hui Wang <hui.wang@canonical.com>,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH 2/8] soundwire: intel: transition to sdw_master_device/driver support
Date: Fri, 28 Feb 2020 08:34:16 +0100 [thread overview]
Message-ID: <20200228073416.GC2898712@kroah.com> (raw)
In-Reply-To: <20200227223206.5020-3-pierre-louis.bossart@linux.intel.com>
On Thu, Feb 27, 2020 at 04:32:00PM -0600, Pierre-Louis Bossart wrote:
> +static struct sdw_master_driver intel_sdw_driver = {
> + .driver = {
> + .name = "intel-master",
> + .owner = THIS_MODULE,
Nit, setting .owner isn't needed anymore, as the core code handles this
for you, right?
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-28 7:35 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 22:31 [PATCH 0/8] soundwire: remove platform devices, add SOF interfaces Pierre-Louis Bossart
2020-02-27 22:31 ` Pierre-Louis Bossart
2020-02-27 22:31 ` [PATCH 1/8] soundwire: bus_type: add master_device/driver support Pierre-Louis Bossart
2020-02-27 22:31 ` Pierre-Louis Bossart
2020-02-28 7:32 ` Greg KH
2020-02-28 7:32 ` Greg KH
2020-02-28 15:53 ` Pierre-Louis Bossart
2020-02-28 15:53 ` Pierre-Louis Bossart
2020-03-03 5:41 ` Vinod Koul
2020-03-03 5:41 ` Vinod Koul
2020-03-03 15:23 ` Pierre-Louis Bossart
2020-03-04 9:53 ` Vinod Koul
2020-03-04 15:17 ` Pierre-Louis Bossart
2020-03-04 16:28 ` Greg KH
2020-03-04 16:28 ` Greg KH
2020-03-05 6:46 ` Vinod Koul
2020-03-05 6:46 ` Vinod Koul
2020-03-05 6:36 ` Vinod Koul
2020-03-05 12:46 ` Pierre-Louis Bossart
2020-03-06 5:01 ` Vinod Koul
2020-03-06 15:40 ` Pierre-Louis Bossart
2020-03-11 6:36 ` Vinod Koul
2020-03-11 14:44 ` Pierre-Louis Bossart
2020-03-13 11:50 ` Vinod Koul
2020-03-13 16:54 ` Pierre-Louis Bossart
2020-03-14 9:49 ` Vinod Koul
2020-03-16 19:15 ` Pierre-Louis Bossart
2020-03-20 15:33 ` Vinod Koul
2020-03-20 16:36 ` Pierre-Louis Bossart
2020-03-23 12:16 ` Vinod Koul
2020-02-27 22:32 ` [PATCH 2/8] soundwire: intel: transition to sdw_master_device/driver support Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-28 7:34 ` Greg KH [this message]
2020-02-28 7:34 ` Greg KH
2020-02-28 16:01 ` Pierre-Louis Bossart
2020-02-28 16:01 ` Pierre-Louis Bossart
2020-03-03 6:05 ` Vinod Koul
2020-03-03 6:05 ` Vinod Koul
2020-02-27 22:32 ` [PATCH 3/8] soundwire: intel_init: add implementation of sdw_intel_enable_irq() Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-27 22:32 ` [PATCH 4/8] soundwire: intel_init: use EXPORT_SYMBOL_NS Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-27 22:32 ` [PATCH 5/8] soundwire: intel/cadence: merge Soundwire interrupt handlers/threads Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-27 22:32 ` [PATCH 6/8] soundwire: intel: add helpers for link power down and shim wake Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-27 22:32 ` [PATCH 7/8] soundwire: intel: add wake interrupt support Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-27 22:32 ` [PATCH 8/8] soundwire: intel_init: save Slave(s) _ADR info in sdw_intel_ctx Pierre-Louis Bossart
2020-02-27 22:32 ` Pierre-Louis Bossart
2020-02-28 7:32 ` [PATCH 0/8] soundwire: remove platform devices, add SOF interfaces Greg KH
2020-02-28 7:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228073416.GC2898712@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.