From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Randy Dunlap <rdunlap@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()
Date: Fri, 28 Feb 2020 19:04:41 +0100 [thread overview]
Message-ID: <20200228180441.GL18400@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200228010342.3j3awgvvgvitif7z@treble>
On Thu, Feb 27, 2020 at 07:03:42PM -0600, Josh Poimboeuf wrote:
> > And why not mark gen8_canonical_addr() __always_inline?
>
> Right, marking those two functions as __always_inline is the other
> option. The problem is, if you keep doing it, eventually you end up
> with __always_inline-itis spreading all over the place. And it affects
> all the other callers, at least in the CONFIG_CC_OPTIMIZE_FOR_SIZE case.
> At least this fix is localized.
I'm all for __always_inline in this case, the compiler not inlining sign
extention is just retarded,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Chris Wilson <chris@chris-wilson.co.uk>,
linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()
Date: Fri, 28 Feb 2020 19:04:41 +0100 [thread overview]
Message-ID: <20200228180441.GL18400@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200228010342.3j3awgvvgvitif7z@treble>
On Thu, Feb 27, 2020 at 07:03:42PM -0600, Josh Poimboeuf wrote:
> > And why not mark gen8_canonical_addr() __always_inline?
>
> Right, marking those two functions as __always_inline is the other
> option. The problem is, if you keep doing it, eventually you end up
> with __always_inline-itis spreading all over the place. And it affects
> all the other callers, at least in the CONFIG_CC_OPTIMIZE_FOR_SIZE case.
> At least this fix is localized.
I'm all for __always_inline in this case, the compiler not inlining sign
extention is just retarded,
next prev parent reply other threads:[~2020-02-28 18:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 22:08 [Intel-gfx] [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl() Josh Poimboeuf
2020-02-27 22:08 ` Josh Poimboeuf
2020-02-27 22:26 ` [Intel-gfx] " Chris Wilson
2020-02-27 22:26 ` Chris Wilson
2020-02-28 16:10 ` [Intel-gfx] " Josh Poimboeuf
2020-02-28 16:10 ` Josh Poimboeuf
2020-02-27 22:35 ` [Intel-gfx] " Al Viro
2020-02-27 22:35 ` Al Viro
2020-02-28 1:03 ` [Intel-gfx] " Josh Poimboeuf
2020-02-28 1:03 ` Josh Poimboeuf
2020-02-28 2:42 ` [Intel-gfx] " Randy Dunlap
2020-02-28 2:42 ` Randy Dunlap
2020-02-28 18:04 ` Peter Zijlstra [this message]
2020-02-28 18:04 ` Peter Zijlstra
2020-02-28 19:56 ` [Intel-gfx] " Al Viro
2020-02-28 19:56 ` Al Viro
2020-02-28 2:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-29 12:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228180441.GL18400@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.