[PATCH 1/2] ARM: dts: exynos: Fix G3D power domain supply on Odroid XU3/XU4/HC1 boards

[PATCH 1/2] ARM: dts: exynos: Fix G3D power domain supply on Odroid XU3/XU4/HC1 boards

[Marek Szyprowski]

G3D power domain in Exynos5422 SoC is supplied from VDD_G3D. Besides the
main GPU MALI module it also contains the power domain control logic and
clocks. Turning the VDD_G3D power supply off causes the power domain to
fail to operate properly and breaks for example system suspend/resume.
GPU should use VDD_G3D supply mainly to control the DVFS.

Fixes: 1a5a85c56402 ("ARM: dts: exynos: Add Mali/GPU node on Exynos5420 and enable it on Odroid XU3/4")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
index 5cf1aed20490..ab27ff8bc3dc 100644
--- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
@@ -901,6 +901,7 @@
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1400000>;
 				regulator-boot-on;
+				regulator-always-on;
 
 				regulator-state-mem {
 					regulator-off-in-suspend;
-- 
2.17.1

[PATCH 2/2] ARM: dts: exynos: Fix G3D power domain supply on Arndale Octa boards

[Marek Szyprowski]

G3D power domain in Exynos5420 SoC is supplied from PVDD_G3DS_1V0 and
PVDD_G3D_1V0. Besides the main GPU MALI module it also contains the power
domain control logic and clocks. Turning the power supplies off causes
the power domain to fail to operate properly if GPU drivers are loaded as
modules. GPU should use PVDD_G3D_1V0 supply mainly to control the DVFS.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index ee28d30f5476..e9a09dd0a49b 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -584,6 +584,7 @@
 				regulator-name = "PVDD_G3DS_1V0";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1100000>;
+				regulator-always-on;
 
 				regulator-state-mem {
 					regulator-on-in-suspend;
@@ -697,6 +698,7 @@
 				regulator-name = "PVDD_G3D_1V0";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1400000>;
+				regulator-always-on;
 
 				regulator-state-mem {
 					regulator-off-in-suspend;
-- 
2.17.1

Re: [PATCH 2/2] ARM: dts: exynos: Fix G3D power domain supply on Arndale Octa boards

[Krzysztof Kozlowski]

On Fri, Feb 28, 2020 at 03:55:02PM +0100, Marek Szyprowski wrote:
> G3D power domain in Exynos5420 SoC is supplied from PVDD_G3DS_1V0 and
> PVDD_G3D_1V0. Besides the main GPU MALI module it also contains the power
> domain control logic and clocks. Turning the power supplies off causes
> the power domain to fail to operate properly if GPU drivers are loaded as
> modules. GPU should use PVDD_G3D_1V0 supply mainly to control the DVFS.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 ++

Thanks, applied.

Best regards,
Krzysztof

Re: [PATCH 1/2] ARM: dts: exynos: Fix G3D power domain supply on Odroid XU3/XU4/HC1 boards

[Krzysztof Kozlowski]

On Fri, Feb 28, 2020 at 03:55:01PM +0100, Marek Szyprowski wrote:
> G3D power domain in Exynos5422 SoC is supplied from VDD_G3D. Besides the
> main GPU MALI module it also contains the power domain control logic and
> clocks. Turning the VDD_G3D power supply off causes the power domain to
> fail to operate properly and breaks for example system suspend/resume.
> GPU should use VDD_G3D supply mainly to control the DVFS.
> 
> Fixes: 1a5a85c56402 ("ARM: dts: exynos: Add Mali/GPU node on Exynos5420 and enable it on Odroid XU3/4")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 1 +

Thanks, applied.

Best regards,
Krzysztof