[PATCH] mesa: add fix for arm6

[PATCH] mesa: add fix for arm6

[Jeremy A. Puhlman]

From: Jeremy Puhlman <jpuhlman@mvista.com>

We have had similar problems with missing atomics on arm6 that arm5
has.

Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
---
 meta/recipes-graphics/mesa/mesa.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index 87f167c507..54d7ea8961 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -161,6 +161,7 @@ EXTRA_OEMESON_append = " -Dasm=false"
 FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
 
 CFLAGS_append_armv5 = " -DMISSING_64BIT_ATOMICS"
+CFLAGS_append_armv6 = " -DMISSING_64BIT_ATOMICS"
 
 # Remove the mesa dependency on mesa-dev, as mesa is empty
 RDEPENDS_${PN}-dev = ""
-- 
2.20.1

Re: [PATCH] mesa: add fix for arm6

[Adrian Bunk]

On Fri, Feb 28, 2020 at 02:51:51PM -0800, Jeremy A. Puhlman wrote:
> From: Jeremy Puhlman <jpuhlman@mvista.com>
> 
> We have had similar problems with missing atomics on arm6 that arm5
> has.

How are you able to reproduce this problem?

I was wondering why the upstream fixes that happened in the meantime 
didn't fix it for armv5, but a qemuarmv5 build of mesa on master worked 
even after commenting out this line.

>...
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -161,6 +161,7 @@ EXTRA_OEMESON_append = " -Dasm=false"
>  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
>  
>  CFLAGS_append_armv5 = " -DMISSING_64BIT_ATOMICS"
> +CFLAGS_append_armv6 = " -DMISSING_64BIT_ATOMICS"
>...

cu
Adrian

BTW: armv6, not arm6 - arm6 is armv3

Re: [PATCH] mesa: add fix for arm6

[Jeremy A. Puhlman]

This was in my queue from a previous yotco version. I haven't gotten my arm
bsp up and running yet. I will double check.

On 2/29/2020 7:37 AM, Adrian Bunk wrote:
> On Fri, Feb 28, 2020 at 02:51:51PM -0800, Jeremy A. Puhlman wrote:
>> From: Jeremy Puhlman <jpuhlman@mvista.com>
>>
>> We have had similar problems with missing atomics on arm6 that arm5
>> has.
> How are you able to reproduce this problem?
>
> I was wondering why the upstream fixes that happened in the meantime
> didn't fix it for armv5, but a qemuarmv5 build of mesa on master worked
> even after commenting out this line.
>
>> ...
>> --- a/meta/recipes-graphics/mesa/mesa.inc
>> +++ b/meta/recipes-graphics/mesa/mesa.inc
>> @@ -161,6 +161,7 @@ EXTRA_OEMESON_append = " -Dasm=false"
>>   FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
>>   
>>   CFLAGS_append_armv5 = " -DMISSING_64BIT_ATOMICS"
>> +CFLAGS_append_armv6 = " -DMISSING_64BIT_ATOMICS"
>> ...
> cu
> Adrian
>
> BTW: armv6, not arm6 - arm6 is armv3
>

-- 
Jeremy A. Puhlman
jpuhlman@mvista.com