From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec
Date: Sun, 1 Mar 2020 07:58:49 -0500 [thread overview]
Message-ID: <20200301075729-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAOEp5Ofzz2CrkbBoPsOAGDVdVJZ07nzH0Usv5h6a96p8+YknwA@mail.gmail.com>
On Sun, Mar 01, 2020 at 02:47:41PM +0200, Yuri Benditovich wrote:
> On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote:
> > > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
> > > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
> > >
> > > Changes from v1:
> > > __virtio -> __le
> > > maximal -> maximum
> > > minor style fixes
> >
> >
> > Looks good to me - sent a bit of consmetics.
> >
> > But as any virtio UAPI change, please CC virtio-dev as virtio TC maintains the
> > interface. Thanks!
>
> Probably 'virtio-dev' should be added to maintainers file.
Doesn't work because it's a subscriber only list.
I've been asking to fix that for years ...
> >
> > > Yuri Benditovich (3):
> > > virtio-net: Introduce extended RSC feature
> > > virtio-net: Introduce RSS receive steering feature
> > > virtio-net: Introduce hash report feature
> > >
> > > include/uapi/linux/virtio_net.h | 90 +++++++++++++++++++++++++++++++--
> > > 1 file changed, 86 insertions(+), 4 deletions(-)
> > >
> > > --
> > > 2.17.1
> >
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Yan Vugenfirer <yan@daynix.com>
Subject: Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec
Date: Sun, 1 Mar 2020 07:58:49 -0500 [thread overview]
Message-ID: <20200301075729-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAOEp5Ofzz2CrkbBoPsOAGDVdVJZ07nzH0Usv5h6a96p8+YknwA@mail.gmail.com>
On Sun, Mar 01, 2020 at 02:47:41PM +0200, Yuri Benditovich wrote:
> On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote:
> > > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
> > > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
> > >
> > > Changes from v1:
> > > __virtio -> __le
> > > maximal -> maximum
> > > minor style fixes
> >
> >
> > Looks good to me - sent a bit of consmetics.
> >
> > But as any virtio UAPI change, please CC virtio-dev as virtio TC maintains the
> > interface. Thanks!
>
> Probably 'virtio-dev' should be added to maintainers file.
Doesn't work because it's a subscriber only list.
I've been asking to fix that for years ...
> >
> > > Yuri Benditovich (3):
> > > virtio-net: Introduce extended RSC feature
> > > virtio-net: Introduce RSS receive steering feature
> > > virtio-net: Introduce hash report feature
> > >
> > > include/uapi/linux/virtio_net.h | 90 +++++++++++++++++++++++++++++++--
> > > 1 file changed, 86 insertions(+), 4 deletions(-)
> > >
> > > --
> > > 2.17.1
> >
next prev parent reply other threads:[~2020-03-01 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 11:07 [PATCH v2 0/3] virtio-net: introduce features defined in the spec Yuri Benditovich
2020-03-01 11:07 ` [PATCH v2 1/3] virtio-net: Introduce extended RSC feature Yuri Benditovich
2020-03-01 11:31 ` Michael S. Tsirkin
2020-03-01 12:43 ` Yuri Benditovich
2020-03-01 11:07 ` [PATCH v2 2/3] virtio-net: Introduce RSS receive steering feature Yuri Benditovich
2020-03-01 11:07 ` [PATCH v2 3/3] virtio-net: Introduce hash report feature Yuri Benditovich
2020-03-01 11:32 ` [PATCH v2 0/3] virtio-net: introduce features defined in the spec Michael S. Tsirkin
2020-03-01 12:47 ` Yuri Benditovich
2020-03-01 12:58 ` Michael S. Tsirkin [this message]
2020-03-01 12:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301075729-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.