From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oscar Carter <oscar.carter@gmx.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
devel@driverdev.osuosl.org,
Malcolm Priestley <tvboxspy@gmail.com>,
linux-kernel@vger.kernel.org,
Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly
Date: Sun, 1 Mar 2020 13:25:14 +0100 [thread overview]
Message-ID: <20200301122514.GA1461917@kroah.com> (raw)
In-Reply-To: <20200301112620.7892-1-oscar.carter@gmx.com>
On Sun, Mar 01, 2020 at 12:26:20PM +0100, Oscar Carter wrote:
> These include module parameters.
>
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> ---
> drivers/staging/vt6656/main_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 5e48b3ddb94c..701300202b21 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -49,12 +49,12 @@ MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION(DEVICE_FULL_DRV_NAM);
>
> #define RX_DESC_DEF0 64
> -static int vnt_rx_buffers = RX_DESC_DEF0;
> +static int __read_mostly vnt_rx_buffers = RX_DESC_DEF0;
> module_param_named(rx_buffers, vnt_rx_buffers, int, 0644);
> MODULE_PARM_DESC(rx_buffers, "Number of receive usb rx buffers");
>
> #define TX_DESC_DEF0 64
> -static int vnt_tx_buffers = TX_DESC_DEF0;
> +static int __read_mostly vnt_tx_buffers = TX_DESC_DEF0;
> module_param_named(tx_buffers, vnt_tx_buffers, int, 0644);
> MODULE_PARM_DESC(tx_buffers, "Number of receive usb tx buffers");
>
Why? What does this help with?
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-01 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 11:26 [PATCH] staging: vt6656: Declare a few variables as __read_mostly Oscar Carter
2020-03-01 12:25 ` Greg Kroah-Hartman [this message]
2020-03-01 13:17 ` Oscar Carter
2020-03-01 15:09 ` Greg Kroah-Hartman
2020-03-07 8:29 ` Oscar Carter
2020-03-09 9:32 ` Quentin Deslandes
2020-03-09 10:34 ` Greg Kroah-Hartman
2020-03-09 11:09 ` Greg Kroah-Hartman
2020-03-02 15:43 ` Quentin Deslandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301122514.GA1461917@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gabrielabittencourt00@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.