From: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To: Oscar Carter <oscar.carter@gmx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Forest Bond <forest@alittletooquiet.net>,
Malcolm Priestley <tvboxspy@gmail.com>,
Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly
Date: Mon, 9 Mar 2020 09:32:10 +0000 [thread overview]
Message-ID: <20200309093210.GA7693@qd-ubuntu> (raw)
In-Reply-To: <20200307082906.GA2948@ubuntu>
On Sat, Mar 07, 2020 at 09:29:06AM +0100, Oscar Carter wrote:
> On Sun, Mar 01, 2020 at 04:09:13PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Mar 01, 2020 at 02:17:01PM +0100, Oscar Carter wrote:
> > This is a USB driver, performance is always limited to the hardware, not
> > the CPU location of variables.
>
> Thank you for the explanation.
>
> >
> > Please always benchmark things to see if it actually makes sense to make
> > changes like this, before proposing them.
>
> I'm sorry.
>
I've been removed from CC list on Greg's answer, so I haven't seen the
explanation earlier and reviewed the patch the next day. I should have
know better, won't happen again.
Thank you,
Quentin
next prev parent reply other threads:[~2020-03-09 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 11:26 [PATCH] staging: vt6656: Declare a few variables as __read_mostly Oscar Carter
2020-03-01 12:25 ` Greg Kroah-Hartman
2020-03-01 13:17 ` Oscar Carter
2020-03-01 15:09 ` Greg Kroah-Hartman
2020-03-07 8:29 ` Oscar Carter
2020-03-09 9:32 ` Quentin Deslandes [this message]
2020-03-09 10:34 ` Greg Kroah-Hartman
2020-03-09 11:09 ` Greg Kroah-Hartman
2020-03-02 15:43 ` Quentin Deslandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309093210.GA7693@qd-ubuntu \
--to=quentin.deslandes@itdev.co.uk \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gabrielabittencourt00@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.