From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname()
Date: Mon, 2 Mar 2020 11:04:56 +0300 [thread overview]
Message-ID: <20200302080456.GD4140@kadam> (raw)
In-Reply-To: <20200227180915.9541-1-digetx@gmail.com>
On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
> This helps to make code cleaner a tad.
Please don't start the commit message in the middle of a sentence.
It looks like this for some of us:
https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2
I generally read the subject or the full commit message but seldom
both.
Otherwise the patch looks very good.
regards,
dan carpenter
next prev parent reply other threads:[~2020-03-02 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:09 [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname() Dmitry Osipenko
2020-03-02 8:04 ` Dan Carpenter [this message]
2020-03-02 15:04 ` Dmitry Osipenko
2020-03-02 15:04 ` Dmitry Osipenko
[not found] ` <d748bf2c-e38c-dabb-59ad-39e14813e40a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-02 15:20 ` Dan Carpenter
2020-03-02 15:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302080456.GD4140@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=digetx@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.