From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mauro Carvalho Chehab
<mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname()
Date: Mon, 2 Mar 2020 18:04:20 +0300 [thread overview]
Message-ID: <d748bf2c-e38c-dabb-59ad-39e14813e40a@gmail.com> (raw)
In-Reply-To: <20200302080456.GD4140@kadam>
02.03.2020 11:04, Dan Carpenter пишет:
> On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
>> This helps to make code cleaner a tad.
>
> Please don't start the commit message in the middle of a sentence.
Could you please clarify what do you mean by the "middle of a sentence"?
The commit's message doesn't sound "middle" to me at all.
> It looks like this for some of us:
>
> https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2
This link points to this patch, I don't quite understand what you're
trying to convey here.
> I generally read the subject or the full commit message but seldom
> both.
The commit's title describes the change briefly, while the message gives
a rational for the change. Usually reviewer should consult the code
changes themselves for more details.
Do you have some kind of a email filter that shows only the commit's
message? Otherwise I'm not sure what's the problem.
> Otherwise the patch looks very good.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname()
Date: Mon, 2 Mar 2020 18:04:20 +0300 [thread overview]
Message-ID: <d748bf2c-e38c-dabb-59ad-39e14813e40a@gmail.com> (raw)
In-Reply-To: <20200302080456.GD4140@kadam>
02.03.2020 11:04, Dan Carpenter пишет:
> On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
>> This helps to make code cleaner a tad.
>
> Please don't start the commit message in the middle of a sentence.
Could you please clarify what do you mean by the "middle of a sentence"?
The commit's message doesn't sound "middle" to me at all.
> It looks like this for some of us:
>
> https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2
This link points to this patch, I don't quite understand what you're
trying to convey here.
> I generally read the subject or the full commit message but seldom
> both.
The commit's title describes the change briefly, while the message gives
a rational for the change. Usually reviewer should consult the code
changes themselves for more details.
Do you have some kind of a email filter that shows only the commit's
message? Otherwise I'm not sure what's the problem.
> Otherwise the patch looks very good.
Thanks
next prev parent reply other threads:[~2020-03-02 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:09 [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname() Dmitry Osipenko
2020-03-02 8:04 ` Dan Carpenter
2020-03-02 15:04 ` Dmitry Osipenko [this message]
2020-03-02 15:04 ` Dmitry Osipenko
[not found] ` <d748bf2c-e38c-dabb-59ad-39e14813e40a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-02 15:20 ` Dan Carpenter
2020-03-02 15:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d748bf2c-e38c-dabb-59ad-39e14813e40a@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.