From: Rob Herring <robh@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
devicetree@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lina Iyer <ilina@codeaurora.org>, Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/7] dt-bindings: power: Extend nodename pattern for power-domain providers
Date: Tue, 3 Mar 2020 11:03:48 -0600 [thread overview]
Message-ID: <20200303170348.GB26191@bogus> (raw)
In-Reply-To: <20200303150749.30566-5-ulf.hansson@linaro.org>
On Tue, Mar 03, 2020 at 04:07:46PM +0100, Ulf Hansson wrote:
> The existing binding requires the nodename to have a '@', which is a bit
> limiting for the wider use case. Therefore, let's extend the pattern to
> allow either '@' or '-'.
That's fine, but...
> Additionally, let's update one of the examples to show how the updated
> pattern could be used.
>
> Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> Documentation/devicetree/bindings/power/power-domain.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml
> index 207e63ae10f9..dc232759013e 100644
> --- a/Documentation/devicetree/bindings/power/power-domain.yaml
> +++ b/Documentation/devicetree/bindings/power/power-domain.yaml
> @@ -25,7 +25,7 @@ description: |+
>
> properties:
> $nodename:
> - pattern: "^(power-controller|power-domain)(@.*)?$"
> + pattern: "^(power-controller|power-domain)([@-].*)?$"
>
> domain-idle-states:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> @@ -71,13 +71,13 @@ required:
>
> examples:
> - |
> - power: power-controller@12340000 {
> - compatible = "foo,power-controller";
> + power: power-domain-foo {
> + compatible = "foo,power-domain";
> reg = <0x12340000 0x1000>;
When you have 'reg' you should have a unit-address.
> #power-domain-cells = <1>;
> };
>
> - // The node above defines a power controller that is a PM domain provider and
> + // The node above defines a power domain that is a PM domain provider and
> // expects one cell as its phandle argument.
>
> - |
> --
> 2.20.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: devicetree@vger.kernel.org,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Lina Iyer <ilina@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] dt-bindings: power: Extend nodename pattern for power-domain providers
Date: Tue, 3 Mar 2020 11:03:48 -0600 [thread overview]
Message-ID: <20200303170348.GB26191@bogus> (raw)
In-Reply-To: <20200303150749.30566-5-ulf.hansson@linaro.org>
On Tue, Mar 03, 2020 at 04:07:46PM +0100, Ulf Hansson wrote:
> The existing binding requires the nodename to have a '@', which is a bit
> limiting for the wider use case. Therefore, let's extend the pattern to
> allow either '@' or '-'.
That's fine, but...
> Additionally, let's update one of the examples to show how the updated
> pattern could be used.
>
> Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> Documentation/devicetree/bindings/power/power-domain.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml
> index 207e63ae10f9..dc232759013e 100644
> --- a/Documentation/devicetree/bindings/power/power-domain.yaml
> +++ b/Documentation/devicetree/bindings/power/power-domain.yaml
> @@ -25,7 +25,7 @@ description: |+
>
> properties:
> $nodename:
> - pattern: "^(power-controller|power-domain)(@.*)?$"
> + pattern: "^(power-controller|power-domain)([@-].*)?$"
>
> domain-idle-states:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> @@ -71,13 +71,13 @@ required:
>
> examples:
> - |
> - power: power-controller@12340000 {
> - compatible = "foo,power-controller";
> + power: power-domain-foo {
> + compatible = "foo,power-domain";
> reg = <0x12340000 0x1000>;
When you have 'reg' you should have a unit-address.
> #power-domain-cells = <1>;
> };
>
> - // The node above defines a power controller that is a PM domain provider and
> + // The node above defines a power domain that is a PM domain provider and
> // expects one cell as its phandle argument.
>
> - |
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-03 17:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 15:07 [PATCH 0/7] dt-bindings: arm: Fix bindings used for hierarchical PSCI states Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-03 15:07 ` [PATCH 1/7] dt-bindings: arm: Correct links to idle states definitions Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-04 14:47 ` Rob Herring
2020-03-04 14:47 ` Rob Herring
2020-03-03 15:07 ` [PATCH 2/7] dt-bindings: arm: Fix cpu compatibles in the hierarchical example for PSCI Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-04 14:47 ` Rob Herring
2020-03-04 14:47 ` Rob Herring
2020-03-03 15:07 ` [PATCH 3/7] dt-bindings: power: Convert domain-idle-states bindings to json-schema Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-03 17:02 ` Rob Herring
2020-03-03 17:02 ` Rob Herring
2020-03-03 20:45 ` Ulf Hansson
2020-03-03 20:45 ` Ulf Hansson
2020-03-03 21:17 ` Rob Herring
2020-03-03 21:17 ` Rob Herring
2020-03-04 14:48 ` Rob Herring
2020-03-04 14:48 ` Rob Herring
2020-03-03 15:07 ` [PATCH 4/7] dt-bindings: power: Extend nodename pattern for power-domain providers Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-03 17:03 ` Rob Herring [this message]
2020-03-03 17:03 ` Rob Herring
2020-03-03 20:46 ` Ulf Hansson
2020-03-03 20:46 ` Ulf Hansson
2020-03-03 15:07 ` [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-03 17:06 ` Rob Herring
2020-03-03 17:06 ` Rob Herring
2020-03-03 20:50 ` Ulf Hansson
2020-03-03 20:50 ` Ulf Hansson
2020-03-04 14:53 ` Rob Herring
2020-03-04 14:53 ` Rob Herring
2020-03-06 18:29 ` Rob Herring
2020-03-06 18:29 ` Rob Herring
2020-03-09 7:10 ` Ulf Hansson
2020-03-09 7:10 ` Ulf Hansson
2020-03-03 15:07 ` [PATCH 6/7] arm64: dts: msm8916: Conform to the domain-idle-state DT binding Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
2020-03-03 15:07 ` [PATCH 7/7] arm64: dts: msm8916: Conform to the nodename pattern for power-domain Ulf Hansson
2020-03-03 15:07 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303170348.GB26191@bogus \
--to=robh@kernel.org \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=benjamin.gaignard@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.